Prevent using .unwrap() and .expect() in codebase

[pan93412]

Abstract

crypto-crawler panics when the data format is invalid, which may have better recoverable way to indicate instead of just aborting the whole tasks.

Solution

Replace all of them to Result<T, SimpleError>:

ws_msg.data.B.parse::<f64>().map_err(|_| SimpleError::new("Failed to parse ws_msg.data.B"));

Besides, I recommended replacing SimpleError to anyhow. It allows us wrapping all the error with a generic Error:

fn parse() -> anyhow::Result<T> {
  // Even simpler than `.unwrap()`. Besides, the `parse()` is recoverable now!
  ws_msg.data.B.parse::<f64>()?;

  // If you need context:
  ws_msg.data.B.parse::<f64>().context("Failed to parse ws_msg.data.B")?;
}

TBDs (To Be Discussed)

• Use anyhow or remain SimpleError? I prefer former.
• Migrate it with less breaking changes (or just make it without writing too many “runtime” to unwrap)

[soulmachine]

Ideally there should be zero unwrap() in code, but it is very difficult to eliminate all unwrap().

I'll look into this issue and decide next step soon.