Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoE and PoM clash #206

Open
rakshita-vijay opened this issue Jul 22, 2024 · 6 comments
Open

PoE and PoM clash #206

rakshita-vijay opened this issue Jul 22, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@rakshita-vijay
Copy link

If a student chooses one, the other should not be available, else it shows that the compres clash.

@skoriop
Copy link
Member

skoriop commented Jul 22, 2024

This was probably caused by #186 considering that's the only PR that affected that part of the codebase, we'll look into it.

@skoriop skoriop added the bug Something isn't working label Jul 22, 2024
@skoriop
Copy link
Member

skoriop commented Jul 22, 2024

@rakshita-vijay We've pushed a hotfix for this, can you try creating a new timetable and verifying if it works?

@rakshita-vijay
Copy link
Author

okay, will try

@rakshita-vijay
Copy link
Author

doesn't show up as a clash, PoM still visible though

@skoriop
Copy link
Member

skoriop commented Jul 23, 2024

doesn't show up as a clash, PoM still visible though

Ok, that's the expected behaviour for now. We'll look into not displaying an unselected optional course in time for the next release (which will be when the main timetable is out) since I don't think this is urgent enough to need another series of hotfixes.

Thanks a lot for reporting this though, we'll keep this issue open until we've done the above and figure out exactly why #186 caused this.

@rakshita-vijay
Copy link
Author

Yes, of course, thank you!

No problem, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants