Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Enterprise Organisations #46

Conversation

gilfthde
Copy link
Contributor

@gilfthde gilfthde commented Feb 8, 2024

Description of your changes

Implements github_enterprise_organization to allow creation of organizations on a GitHub Enterprise account.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Replaces #41

@gilfthde
Copy link
Contributor Author

gilfthde commented Feb 8, 2024

I don't know how to provide an end-to-end test for this because a GitHub Enterprise is required for the operation.

@AtzeDeVries
Copy link
Collaborator

@gilfthde after 'update' branch it fails. I updated to go 1.21 which causes some libs to be updated as well. Can you make sure all generated is code is commited again? thanks!

@gilfthde
Copy link
Contributor Author

gilfthde commented Feb 9, 2024

@AtzeDeVries Generated should be up-to-date now.

@AtzeDeVries
Copy link
Collaborator

@gilfthde Thanks. I'll merge it and publish in v0.6.0

@AtzeDeVries AtzeDeVries merged commit 073f6a1 into crossplane-contrib:main Feb 9, 2024
6 checks passed
@AtzeDeVries
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants