Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

README Addition #163

Open
natereid72 opened this issue Feb 21, 2022 · 5 comments · May be fixed by #167
Open

README Addition #163

natereid72 opened this issue Feb 21, 2022 · 5 comments · May be fixed by #167

Comments

@natereid72
Copy link

Can we add requirement for Kubernetes API server version =>v1.23 to the README?

@jbw976
Copy link
Member

jbw976 commented Feb 22, 2022

Feel free to open a PR with this contribution @natereid72, along with the explanation/details for why that version is needed :)

@natereid72
Copy link
Author

I'll close that PR and open a new one tomorrow. Need to switch laptops to sign.

@natereid72
Copy link
Author

idk, @jbw976 we may need to sync tomorrow on this. I signed it but DCO still showing issue with not signed,

@bobh66
Copy link

bobh66 commented Feb 22, 2022

Since this is an AWS provider, I assume a lot of people (like me) will be running it on EKS, which only supports up to Kubernetes 1.21. I think a recommendation of 1.23 would be fine, with an explanation of what the issue(s) are with earlier versions.

@natereid72 natereid72 linked a pull request Feb 22, 2022 that will close this issue
2 tasks
@natereid72
Copy link
Author

ok, replaced previous PR with #167. Git amend didn't seem to fix the sign-off issue in previous PR. Added statement on requirement and brief reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants