Ignore newly added clippy warnings #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Zmiri-retag-fields is now enabled by default.
``` warning: usage of an `Arc` that is not `Send` or `Sync` --> crossbeam-epoch/src/collector.rs:32:21 | 32 | global: Arc::new(Global::new()), | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: the trait `Sync` is not implemented for `Global` = note: required for `Arc<Global>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default ```
```
warning: sub-expression diverges
--> crossbeam-channel/tests/array.rs:639:21
|
639 | send(s, panic!()) -> _ => panic!(),
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
= note: `#[warn(clippy::diverging_sub_expression)]` on by default
= note: this warning originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: sub-expression diverges
--> crossbeam-channel/tests/select_macro.rs:470:25
|
470 | send(get(), panic!()) -> _ => {}
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
= note: `#[warn(clippy::diverging_sub_expression)]` on by default
= note: this warning originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
```
```
warning: used `unwrap_or()` on `Some` value
--> crossbeam-channel/tests/select_macro.rs:959:14
|
959 | recv(Some(&r).unwrap_or(&never())) -> _ => {},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
= note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
help: remove the `Some` and `unwrap_or()`
|
959 - recv(Some(&r).unwrap_or(&never())) -> _ => {},
959 + recv(&r) -> _ => {},
|
warning: used `unwrap_or()` on `Some` value
--> crossbeam-channel/tests/select_macro.rs:963:14
|
963 | recv(Some(r).unwrap_or(never())) -> _ => {},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
help: remove the `Some` and `unwrap_or()`
|
963 - recv(Some(r).unwrap_or(never())) -> _ => {},
963 + recv(r) -> _ => {},
|
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.