We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Right now, even if you use none of the default icons, they're included in your final bundle, adding a lot of bundle size.
To Reproduce Steps to reproduce the behavior:
Expected behavior Unused icons should not increase final bundle size
Screenshots
The text was updated successfully, but these errors were encountered:
For additional context, when analyzing minerva-ui using bundlephobia, almost 60% of the bundle size is from the icons.
We should probably rethink this or make it a separate package to avoid it being included unnecessarily
Sorry, something went wrong.
Also, some components (like modals and and menus) use the icons. We might need to hard-code those to be included
Update: I don't think I know how tree shaking works with TSDX. Maybe we should remove react-feather altogether.
react-feather
No branches or pull requests
Describe the bug
Right now, even if you use none of the default icons, they're included in your final bundle, adding a lot of bundle size.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Unused icons should not increase final bundle size
Screenshots
The text was updated successfully, but these errors were encountered: