Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash repl should remember session settings #319

Open
mfussenegger opened this issue Mar 10, 2020 · 0 comments
Open

Crash repl should remember session settings #319

mfussenegger opened this issue Mar 10, 2020 · 0 comments

Comments

@mfussenegger
Copy link
Member

The REPL behavior of crash is now not intuitive because statements like SET search_path = .. seem to have no effect.

The reason for that is that crash uses crate-python. crate-python uses HTTP and CrateDB creates a new session per request. Because of that session settings are always discarded.

We could change this behavior on the server side for HTTP. But given that some clients use round-robin, starting to keep the session settings could result in confusing behavior as well. The session setting would be set on a single node, and a follow up request to another node wouldn't have it set.

We could migrate crash to use something like asyncpg to work around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants