Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wishlist] Please add a type for COMMIT_EDITMSG files #1117

Open
zaufi opened this issue Oct 9, 2024 · 1 comment
Open

[wishlist] Please add a type for COMMIT_EDITMSG files #1117

zaufi opened this issue Oct 9, 2024 · 1 comment
Labels
enhancement Improve the expected

Comments

@zaufi
Copy link

zaufi commented Oct 9, 2024

I use typos also to check Git commit messages. Git automatically adds what's changed in the commit message file as git diff output and it may contain typos I want to exclude from checks. For example, index <git-hash-1>..<git-hash-2> <filemode> may cause errors like this:

error: `ba` should be `by`, `be`
  --> /path/to/my/repo/.git/COMMIT_EDITMSG:61:9
   |
61 | index a0ba5a281..ab42b8917 100644
   |         ^^
   |

It'll be nice to be able to add extend-ignore-re regexes for this type of file.

@zaufi zaufi changed the title [FeatureReq] Please add a type for COMMIT_EDITMSG files [wishlist] Please add a type for COMMIT_EDITMSG files Oct 9, 2024
@epage
Copy link
Collaborator

epage commented Oct 9, 2024

In addition to COMMIT_EDITMSG, know of any other "well known" files that git deals with?

Ah, found what neovim does:
https://github.com/neovim/neovim/blob/8ef3dd3afa20024f439d8b7a69f316069c1909d3/runtime/lua/vim/filetype.lua#L1532-L1536

Hmm, in general it might be good to review that. I don't know if we'd want to add all of their file types but would be good to at least add any file names we are missing for our file types.

@epage epage added the enhancement Improve the expected label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants