-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: option to require non-capitalized subjects #408
Comments
I'm fine adding a check for non-capitalized subjects. I'd prefer to not make a breaking change in the configuration format though. I'd be open to other ideas. |
Thanks for considering! Adding Adding |
Due to some recent work, Rust lints are heavily on my mind since I last spoke. I also forgot that I've been toying with moving in a lint level-like direction.
This is the approach rustc takes for lint naming
clippy even has mutually exclusive lints, though they limit those to a specific group, Hmm, however, the problem is with defaults. With clippy, Sounds like we do need to go with an enumeration. Thinking more on this, I feel like maybe it is more correct to say |
When I've done these migrations in the past, I've errored out if both are explicitly set because that is ambiguous. I don't think we should prefer one over the other. |
Requiring commit subjects not to be capitalized is a common practice especially with conventional commit implementations. There does not seem to be a way to enforce this with committed, and it would be nice to have.
Setting
subject_capitalized
to false does not appear to result in capitalized subjects flagged as an error, it just does not require them to be capitalized then. Perhaps it could be changed to a tri-state option so that if not defined, no particular case is required; if true, capitalization required; if false, non-capitalization required.Some references
The text was updated successfully, but these errors were encountered: