Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template for performing release to crates.io #34

Closed
jonhoo opened this issue Jul 18, 2019 · 6 comments
Closed

Template for performing release to crates.io #34

jonhoo opened this issue Jul 18, 2019 · 6 comments

Comments

@jonhoo
Copy link
Collaborator

jonhoo commented Jul 18, 2019

See https://twitter.com/thramp/status/1151842961648476160.

It'd be neat if certain commits to master (or some particular branch) could automatically trigger cargo publish (including for sub-crates).

@epage
Copy link
Contributor

epage commented Jul 18, 2019

cargo-release takes care of all of the little things and has workspace support. crate-ci/cargo-release#117 is working to come up with what an auto-release workflow would look like.

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jul 18, 2019

I wonder what running cargo-release from CI would look like. In some sense I wonder if CI should just do the publishing, and not the git-related stuff. Basically, you tag a commit as a release, and then CI does the rest.

@epage
Copy link
Contributor

epage commented Jul 18, 2019

I wonder what running cargo-release from CI would look like. In some sense I wonder if CI should just do the publishing, and not the git-related stuff. Basically, you tag a commit as a release, and then CI does the rest.

cargo-release is fairly configurable so we could possibly define configurations for it that split the two sides. One of the oddities is if you tag, update versionss and update dependencies all within the same commit or do you let it bubble up?

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jan 20, 2020

I think this is now explicitly out-of-scope. If your project wants this, it should write a job that uses the install-rust template and then does cargo release.

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jan 20, 2020

See also #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants