Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we verify minimal dependency versions #25

Closed
epage opened this issue Jul 15, 2019 · 6 comments
Closed

Should we verify minimal dependency versions #25

epage opened this issue Jul 15, 2019 · 6 comments
Labels
question Further information is requested

Comments

@epage
Copy link
Contributor

epage commented Jul 15, 2019

cargo has an unstable flag to calculate dependencies using the minimum rather than the maximum version. This verifies that Cargo.tomls are not stale.

@epage epage added the question Further information is requested label Jul 15, 2019
@epage
Copy link
Contributor Author

epage commented Jul 15, 2019

The downside is the brittleness of dependencies if they aren't also verifying it.

@jonhoo
Copy link
Collaborator

jonhoo commented Jul 15, 2019

I think this should be an opt-in stage. Not sure what Rust version it should be run on (does it require nightly atm?).

@epage
Copy link
Contributor Author

epage commented Jul 15, 2019

I think you can use unstable flags without nightly but I'm unsure. I at least do it with libtest's json output.

@epage
Copy link
Contributor Author

epage commented Jul 15, 2019

As for best practices, I am unsure. I've seen discussions around this but haven't adopted it myself (yet). I've been tempted to adopt it due to minrust issues.

@jonhoo
Copy link
Collaborator

jonhoo commented Jul 28, 2019

Relevant: rust-lang/api-guidelines#123

@jonhoo
Copy link
Collaborator

jonhoo commented Jan 20, 2020

Closing this in favor of #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants