Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run rustfmt/clippy on nightly #29

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Don't run rustfmt/clippy on nightly #29

merged 1 commit into from
Jul 15, 2019

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Jul 15, 2019

Too many spurious failures, which lead to people ignoring errors.

Fixes #18

Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with the change, I don't think this fixes the concern raised in #18

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jul 15, 2019

I think this is a step in the right direction, though you're right it doesn't fix the deeper disagreement about how CI should work there. I'll change it to not mark #18 as fixed.

Too many spurious failures, which lead to people ignoring errors.

Progress towards #18.
@jonhoo jonhoo force-pushed the style-stability branch from 7cd3cd3 to 7ae39db Compare July 15, 2019 17:48
@jonhoo jonhoo merged commit 93c945c into master Jul 15, 2019
@jonhoo jonhoo deleted the style-stability branch July 15, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run clippy on a fixed version of rustc
2 participants