Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respectful request to remove package #6

Open
dandv opened this issue Feb 13, 2014 · 7 comments
Open

Respectful request to remove package #6

dandv opened this issue Feb 13, 2014 · 7 comments

Comments

@dandv
Copy link
Contributor

dandv commented Feb 13, 2014

Thanks for publishing this package. In the meantime, Moment.js is being maintained on Atmosphere according to current best practices - https://github.com/acreeger/meteor-moment

Kindly consider removing this package. Thanks!

@dandv
Copy link
Contributor Author

dandv commented Mar 15, 2014

Re.

I strongly disagree with your request to remove this package from atmosphere, as it would suddenly break our app on deploy without any warning!

I can sympathize with that. On the other hand, the earlier the package is removed, the earlier others that depend on it can switch over. Wish there was a mechanism to instruct mrt to warn the user when installing packages marked as "will be deprecated".

@crapthings
Copy link
Owner

i've tried removePackage 'momentjs', but there's no response, what's wrong ?

Meteor.call('addPackageMaintainer', 'momentjs', 'crapthings');

Meteor.call('deletePackage', 'momentjs', function() {console.log(arguments)});

@dandv
Copy link
Contributor Author

dandv commented Mar 16, 2014

@Tarangp might be able to help (see above).

@Tarang
Copy link

Tarang commented Mar 16, 2014

@crapthings What do you get when you run this (make sure you're logged into atmosphere first)

Meteor.call('deletePackage', 'momentjs', function(err, result) {
    console.log(err,result);
});

@dandv
Copy link
Contributor Author

dandv commented Nov 14, 2014

Hey @crapthings , can you try running this to rm the package from Atmo:

meteor admin set-unmigrated mrt:momentjs

Thanks!

@crapthings
Copy link
Owner

hey dandv i've got this after running code.

Setting mrt:[email protected] as unsuccessfully migrated ...Error from package server: You are not an authorized maintainer for this package. [401]
monsterstep:japn zhanghong$ meteor whoami
crapthings
monsterstep:japn zhanghong$ meteor admin set-unmigrated mrt:momentjs
Setting mrt:[email protected] as unsuccessfully migrated ...Error from package server: You are not an authorized maintainer for this package. [401]
monsterstep:japn zhanghong$

@crapthings
Copy link
Owner

oh wait.

done

monsterstep:japn zhanghong$ meteor admin set-unmigrated crapthings:momentjs
monsterstep:japn zhanghong$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants