Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool_musicxml2hum::getSystemDecoration converts both "bracket" and "brace" to "[(...)]" #51

Open
gregchapman-dev opened this issue Jul 13, 2022 · 1 comment

Comments

@gregchapman-dev
Copy link
Contributor

"brace" should be "{(...)}". I think this is just a copy/paste error.

@craigsapp
Copy link
Owner

Thanks! I set two staves to have the style {( ... )} by default, so I don't use it myself since I delete the system decorations for piano music, which is probably the reason why I didn't notice the problem (or I started deleting it because it was doing square brackets due to the typo).

Checking the rendering in verovio, everything seems to be working properly:

**kern	**kern
*staff2	*staff1
*part1	*part1
1C	1c
=	=
*-	*-
!!!system-decoration: {(s1,s2)}

Screenshot 2023-02-04 at 4 23 35 PM

Styling by part rather than staves:

**kern	**kern
*staff2	*staff1
*part1	*part1
*group1	*group1
1C	1c
=	=
*-	*-
!!!system-decoration: {(p1)}

Screenshot 2023-02-04 at 4 23 35 PM

And using *group#:

**kern	**kern
*staff2	*staff1
*part1	*part1
*group1	*group1
1C	1c
=	=
*-	*-
!!!system-decoration: {(g1)}

Screenshot 2023-02-04 at 4 16 52 PM


Without connecting barlines between staves:

**kern	**kern
*staff2	*staff1
*part1	*part1
*group1	*group1
1C	1c
=	=
*-	*-
!!!system-decoration: {s1,s2}

Screenshot 2023-02-04 at 4 26 04 PM

By parts:

**kern	**kern
*staff2	*staff1
*part1	*part1
*group1	*group1
1C	1c
=	=
*-	*-
!!!system-decoration: {p1}

Screenshot 2023-02-04 at 4 26 41 PM

Using *group#:

**kern	**kern
*staff2	*staff1
*part1	*part1
*group1	*group1
1C	1c
=	=
*-	*-
!!!system-decoration: {g1}

Screenshot 2023-02-04 at 4 27 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants