Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-tag-action runs too often #86

Open
jawys opened this issue Sep 4, 2023 · 2 comments
Open

github-tag-action runs too often #86

jawys opened this issue Sep 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jawys
Copy link
Contributor

jawys commented Sep 4, 2023

Description

Hey @timkelty, it's me again.

I noticed that there are a lot of duplicate git tags on a single git commit, probably because of the scheduled (nightly) builds

Steps to reproduce

See commit refs of tags, e.g. 74b77e0:
grafik
grafik

@jawys jawys added the bug Something isn't working label Sep 4, 2023
@timkelty
Copy link
Collaborator

timkelty commented Sep 4, 2023

@jawys That is actually intentional. Even though our code hasn't changed, the Github action rebuilds the docker image so we get any CVEs from upstream.

That said, how I'm triggering it from tags probably doesn't make as much sense.

It might make sense to just do this with docker tags instead, tagging the images something like craftcms/php-fpm:8.2-latest and craftcms/php-fpm:8.2-74b77e0.

@jawys
Copy link
Contributor Author

jawys commented Sep 4, 2023

the Github action rebuilds the docker image so we get any CVEs from upstream.

Yes I followed the CVE issues ;)


Maybe you could tag on pushes to main only (merges mostly) or even extract the bump job into another github actions yml?
And builds could run on tags + schedules, same as now.


It might make sense to just do this with docker tags instead, tagging the images something like craftcms/php-fpm:8.2-latest and craftcms/php-fpm:8.2-74b77e0.

I like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants