Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy warnings for lesson 0 & 1 #5

Open
0xBachmann opened this issue Jul 7, 2022 · 4 comments
Open

clang-tidy warnings for lesson 0 & 1 #5

0xBachmann opened this issue Jul 7, 2022 · 4 comments

Comments

@0xBachmann
Copy link

consider adding '-readability-named-parameter' to the clang-tidy file, otherwise trying to build the project will fail for lesson 0 and 1 as there are a lot of unnamed parameters in those lesson. thanks for your work it is super fun to play around with your game

@lefticus
Copy link
Member

lefticus commented Jul 7, 2022

Can you verify what clang-tidy you are using? many different versions run on several targets on the CI, and I'm not getting any of those failures.

@0xBachmann
Copy link
Author

I use version 10 (x86_64-pc-linux-gnu) but just realized, that the problem occurred not with any of the lessons but with the game itself, only there are lambdas with unnamed parameters.

@arun5309
Copy link

I am facing the same issue when clang-tidy (LLVM version: 12.0.1) is checking game.cpp, game_components.cpp and all game hacking lesson files. Adding '-readability-named-parameter' to the clang-tidy file didn't fix the issue for me. So, I added '/unused/' in place of the unnamed parameters and it fixed it for me.

@lefticus
Copy link
Member

OK, I'll look into this this week. I just got back from a bunch of training and conference travel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants