Align docs and dependencies #18
Conversation
lefticus
commented
Apr 1, 2022
•
lefticus
commented
- upgrade project_options
- consider forking project_options
- update cmake version required
- check documents for required compilers/C++ verison
|
Note @ddalcino this is based onto develop so it can easily be fully vetted before merging. |
Codecov Report
@@ Coverage Diff @@
## develop #18 +/- ##
========================================
Coverage 77.77% 77.77%
========================================
Files 3 3
Lines 36 36
Branches 19 19
========================================
Hits 28 28
Misses 7 7
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
According to https://en.cppreference.com/w/cpp/compiler_support, there are still C++20 features that are as yet unsupported by clang. GCC 11 and the current release of Visual Studio 2019 both have full support for C++20. It's possible that earlier versions of clang, GCC, and MSVC can successfully compile cpp_boilerplate_project. However, I think it's disingenuous to tell our users that an older version will work when they start using C++20 features that aren't demonstrated in the project. It is my contention that we are already testing the oldest compilers that are compatible with the project; we just need to update the README to reflect the new versions. |
Many of the optional dependencies will trigger warnings on build if they are not installed. If they are not strongly encouraged to install these, it is likely that many users will simply ignore them and trigger the warnings.
The GUI libraries are in cpp_starter_project, not cpp_boilerplate_project, so they do not need to be discussed here.
README_dependencies.md
Outdated
| - Debian/Ubuntu: | ||
| - Ubuntu 21.04+: | ||
|
|
||
| sudo apt install gcc-11 | ||
|
|
||
| - Ubuntu 18.04-20.04: | ||
|
|
||
| sudo apt install build-essential | ||
| sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test && sudo apt-get update -qq | ||
| sudo apt install gcc-11 |
There was a problem hiding this comment.
This probably deserves comment. I am removing instructions on how to install gcc-11 on Debian.
I've looked into installing gcc-11 on Debian briefly, and it looks complicated enough that I would have to manually test the instructions I've found. I'm not going to do that, because Debian not widely used. I think it would make more sense to add instructions for Arch-derived distros and Fedora.
|
Is there anything left to do here? Do we really need to fork |
|
Whoa, that merge really didn’t work out. I’m not clear on what happened to Visual Studio, and I really wasn’t expecting the template janitor to fire. Any ideas here? |
