fix: Stop propagation of event

This avoids triggering events for elements below the component, for example in Banks there are chips integrated into ListItems
cozy · Feb 9, 2024 · 167e50b · 167e50b
1 parent 50e0248
commit 167e50b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/react/IntentDialogOpener/IntentDialogOpener.jsx b/react/IntentDialogOpener/IntentDialogOpener.jsx
@@ -28,6 +28,7 @@ const IntentDialogOpener = props => {
 
   const openModal = ev => {
     ev.preventDefault()
+    ev.stopPropagation()
     setModalOpened(true)
   }
   const closeModal = () => setModalOpened(false)

diff --git a/react/deprecated/IntentModal/IntentModal.jsx b/react/deprecated/IntentModal/IntentModal.jsx
@@ -46,9 +46,9 @@ class IntentModal extends Component {
   // FIXME: this should be fixed by diferenciating dismissAction (for closing
   // modal) and onCancel (for intent cancellation), but it implies deprecating
   // dismissAction first, ensure legacy, prevent regressions, etc.
-  dismiss = once(() => {
+  dismiss = once(evt => {
     const { dismissAction } = this.props
-    dismissAction && dismissAction()
+    dismissAction && dismissAction(evt)
   })
 
   render() {