Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sharing banner blinks #3259

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: Sharing banner blinks #3259

merged 1 commit into from
Dec 4, 2024

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Dec 4, 2024

When sharing with Cozy and already Added, the share banner should never appear.

Before this fix, it could blink on loading.

When sharing with Cozy and already Added,
the share banner should never appear.

Before this fix, it could blink on loading.
@Merkur39 Merkur39 requested a review from zatteo December 4, 2024 11:42
@Merkur39 Merkur39 requested a review from acezard as a code owner December 4, 2024 11:42
Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Unchanged files (18)
Status Path Size Limits
vendors/drive.(hash).js
1.83MB 2MB
public/drive.(hash).js
1.59MB 1.7MB
public/pdf.worker.entry.(hash).worker.js
345.35KB 350KB
services/qualificationMigration/drive.js
282.43KB 500KB
services/dacc/drive.js
263.32KB 500KB
public/cozy-client-js.js
159.28KB 160KB
app/drive.(hash).js
156.92KB 300KB
intents/drive.(hash).js
97.24KB 190KB
public/drive.(hash).min.css
39.47KB 100KB
onlyOffice/slide.pptx
24.83KB 25KB
app-drive.(hash).min.css
10.7KB 56KB
intents-drive.(hash).min.css
8.44KB 40KB
onlyOffice/text.docx
5.85KB 6KB
onlyOffice/spreadsheet.xlsx
5.02KB 6KB
manifest.webapp
1.87KB 2KB
index.html
598B 1KB
intents/index.html
507B 1KB
manifest.json
185B 1KB

Total files change -3B 0%

Unchanged groups (7)
Status Path Size Limits
public/**
2.14MB -
vendors/**
1.83MB -
services/**
545.74KB -
app/**
156.92KB -
intents/**
97.74KB -
onlyOffice/**
35.7KB -
img/**
5.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Merkur39 Merkur39 merged commit a1fc21f into master Dec 4, 2024
4 checks passed
@Merkur39 Merkur39 deleted the fix/vo-1202 branch December 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants