Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve share wording into confirm delete modal #2980

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

cballevre
Copy link
Contributor

### ✨ Features

*  Improve share wording into confirm delete modal

@cballevre cballevre requested a review from zatteo as a code owner September 4, 2023 12:38
@bundlemon
Copy link

bundlemon bot commented Sep 4, 2023

BundleMon

Files updated (3)
Status Path Size Limits
drive/intents/drive.(hash).js
150.4KB (+1.71KB +1.15%) 171KB
drive/public/drive.(hash).js
1.49MB (+1.3KB +0.08%) 1.65MB
drive/app/drive.(hash).js
243.89KB (+1.29KB +0.53%) 255KB
Unchanged files (16)
Status Path Size Limits
drive/vendors/drive.(hash).js
1.28MB 1.6MB
drive/public/pdf.worker.entry.(hash).worker.j
s
343.37KB 345KB
drive/services/dacc/drive.js
253.91KB 500KB
drive/services/qualificationMigration/drive.j
s
248.95KB 500KB
drive/public/cozy-client-js.js
158.97KB 160KB
drive/public/drive.(hash).min.css
92.62KB 100KB
drive/app-drive.(hash).min.css
55.72KB 56KB
drive/intents-drive.(hash).min.css
37.06KB 40KB
drive/onlyOffice/slide.pptx
24.82KB 25KB
drive/onlyOffice/text.docx
5.84KB 6KB
drive/onlyOffice/spreadsheet.xlsx
5.01KB 6KB
drive/manifest.webapp
1.77KB 2KB
drive/index.html
532B 1KB
drive/intents/index.html
514B 1KB
drive/img/app-icon.(hash).svg
419B 1KB
drive/manifest.json
184B 1KB

Total files change +4.3KB +0.1%

Groups updated (3)
Status Path Size Limits
drive/intents/**
150.9KB (+1.71KB +1.15%) +6%
drive/public/**
2.09MB (+1.3KB +0.06%) +7%
drive/app/**
243.89KB (+1.29KB +0.53%) +1%
Unchanged groups (5)
Status Path Size Limits
drive/screenshots/**
2.13MB +0.4%
drive/vendors/**
1.28MB +6%
drive/services/**
502.86KB +1%
drive/onlyOffice/**
35.68KB +0.4%
drive/img/**
419B +0.4%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

return acc && current === statuses[0]
}, true)

let shareMessageType = !isStatusesEqual
Copy link
Contributor

@zatteo zatteo Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a point of view: I find nested ternary difficult to read. But do not change.

@cballevre cballevre merged commit 2b0029b into master Sep 4, 2023
3 checks passed
@cballevre cballevre deleted the feat/improve-share-wording-into-confirm-delete branch September 4, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants