Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optional auction_id field to /settle and /reveal requests #3131

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Added optional auction_id field to /settle and /reveal requests #3131

merged 7 commits into from
Nov 20, 2024

Conversation

mstrug
Copy link
Contributor

@mstrug mstrug commented Nov 19, 2024

Description

Update to PR #3113 which changes auction_id field to be optional.

@mstrug mstrug marked this pull request as ready for review November 19, 2024 23:52
@mstrug mstrug requested a review from a team as a code owner November 19, 2024 23:52
@squadgazzz
Copy link
Contributor

squadgazzz commented Nov 20, 2024 •
edited
Loading

Wouldn't it be easier to revert the initial PR entirely until all the colocated solvers support the new field? My bad, I forgot they depend on our driver crate.

squadgazzz
squadgazzz approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstrug mstrug merged commit 9859675 into main Nov 20, 2024
11 checks passed
@mstrug mstrug deleted the api/driver-add-auction-id-optional branch November 20, 2024 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

@squadgazzz squadgazzz squadgazzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstrug @squadgazzz @m-lord-renkse