chore: Switch solution_id from string to integer
#3064
Assignees
Comments
2 tasks
Merged
sunce86
added a commit
that referenced
this issue
Oct 18, 2024
# Description Related to #3064 This PR enables driver to send either string or integer for `solution_id`. This PR marks the start of transition period. Once the PR is merged, external solvers will be asked to: 1. Start sending `solution_id` as integer in `/solve` response. 2. Implement receiving either string or integer for `solution_id` on `/reveal` and on `/settle`. Once done, backend will have a [follow up](#3072) where we will definitely switch to using integers in all three endpoints and #3064 will be fixed. ## How to test Manually checked that both versions are properly serialized/deserialized. <!-- ## Related Issues Fixes # -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Switch solution id from string to integer
https://github.com/cowprotocol/services/blob/main/crates/autopilot/src/infra/solvers/dto/solve.rs#L173-L174
Use enum to enable one week of transition period where both integer and strings will be allowed. Communicate the change to solvers.
The text was updated successfully, but these errors were encountered: