[orderbook] Use alternative memory allocator #2812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
The plan is to test jemalloc and then mimalloc.
In the spirit of moving fast and getting over this issue ASAP, let's only test one (unless you can bring up a good argument what you expect from mimalloc specifically that cannot be confirmed with jemalloc).
If it works, let's use jemalloc, otherwise let's move on.
|
Closing since neither jemalloc nor mimalloc helped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out to use alternative memory allocators. The plan is to test
jemallocand thenmimalloc. Requires an infra PR to configure them through env params.Important
Should not be merged until a positive result is confirmed.