Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autopilot configuration to define observable solver addresses #2722

Closed
Tracked by #2716
sunce86 opened this issue May 11, 2024 · 2 comments
Closed
Tracked by #2716

Add autopilot configuration to define observable solver addresses #2722

sunce86 opened this issue May 11, 2024 · 2 comments
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details stale

Comments

@sunce86
Copy link
Contributor

sunce86 commented May 11, 2024

Context provided #2667

Since the barn and production environment operate on separate auction but share the same settlement contract instance, we probably cannot simply audit all settlement events that are emitted and ban if a settlement is emitted "out of competition". If we did, the prod autopilot would have to check the barn autopilot if a settlement satisfied its competition and vice versa. Moreover, there are some legit out of competition settlements (e.g. for periodic fee withdrawals). I'd suggest configuring each driver with a set of allow-listed solver addresses it tracks settlements for (and ignores all other settlements).

This issue captures adding the configuration parameter where for each environment autopilot is given a list of solver addresses the settlement update needs to monitor. Once we have this list of addresses, OnSettlementEvenUpdater needs to be updated to skip checking all other senders.

@sunce86 sunce86 added the E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details label May 11, 2024
@MartinquaXD
Copy link
Contributor

OnSettlementEvenUpdater needs to be updated to skip checking all other senders

One thing to note is that we can run into issues when we have to re-index solutions of solvers that have been deprecated since the transaction happened. I think this is a very minor edge case but IMO we still need to be aware that it exists.

Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details stale
Projects
None yet
Development

No branches or pull requests

2 participants