Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Verify appData in one place in the orderbook #2449

Closed
m-lord-renkse opened this issue Feb 29, 2024 · 3 comments
Closed

chore: Verify appData in one place in the orderbook #2449

m-lord-renkse opened this issue Feb 29, 2024 · 3 comments
Labels

Comments

@m-lord-renkse
Copy link
Contributor

Background

The appData verification is scattered around. Unify the appData verification in one place, and propagate the appData to the functions accordingly.

Details

We should have validated appData (app_data::Validator) which can be provided by:provide appdata in so many ways:

  • just a string
  • just the appData (only needs to be verified that we have it in our DB)
  • string + hash so we can verify if the string matches the one in our DB

Acceptance criteria

The appData validation is in one place, and it is properly propagated accordingly.

Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the Stale label Apr 30, 2024
@mfw78 mfw78 removed the Stale label May 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jul 4, 2024
@mfw78 mfw78 removed the stale label Jul 10, 2024
Copy link

github-actions bot commented Sep 9, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants