You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are limiting the number of limit orders a single account can have to something like 50 (to avoid uncontrolled growth of the orderbook). This limit would historically not apply to market orders (swap orders that are expected to execute immediately).
However, with the recent change of submitting all orders with 0 fee amount, the backend no longer differentiates between swap (in market) limit orders and potentially long standing (out of market) limit orders.
This can cause issues with certain use cases where users are trying to create a lot of short lived swaps (e.g. dump.services).
Details
This issue tracks work to distinguish between limit orders that are currently expected to be executed (in market price) and not count those towards the total order limit per user.
Acceptance criteria
A user can dump more than 50 tokens at the same time without running into order limit restrictions.
The text was updated successfully, but these errors were encountered:
# Description
Only check for order limits when the orders are class "Limit". I kept
the legacy code/behavior, in order not to make a regression breaking
change.
# Changes
- Only do the order limit check if the order is class "Limit" and it is
not "in-market"
## How to test
1. Unit test
2. e2e test
Fixes#2433
Background
We are limiting the number of limit orders a single account can have to something like 50 (to avoid uncontrolled growth of the orderbook). This limit would historically not apply to market orders (swap orders that are expected to execute immediately).
However, with the recent change of submitting all orders with 0 fee amount, the backend no longer differentiates between swap (in market) limit orders and potentially long standing (out of market) limit orders.
This can cause issues with certain use cases where users are trying to create a lot of short lived swaps (e.g. dump.services).
Details
This issue tracks work to distinguish between limit orders that are currently expected to be executed (in market price) and not count those towards the total order limit per user.
Acceptance criteria
A user can dump more than 50 tokens at the same time without running into order limit restrictions.
The text was updated successfully, but these errors were encountered: