Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Get rid of trace_many dependency in bad token detection #2412

Closed
MartinquaXD opened this issue Feb 19, 2024 · 3 comments
Closed

chore: Get rid of trace_many dependency in bad token detection #2412

MartinquaXD opened this issue Feb 19, 2024 · 3 comments

Comments

@MartinquaXD
Copy link
Contributor

MartinquaXD commented Feb 19, 2024

Background

Currently our bad token detection requires a node that supports trace_many which for example rules out geth. It should be possible to implement a similar logic using helper solidity contracts we use with state overrides.
This would basically trade in the dependency on trace_many with state overrides. But we already have a very big dependency on that so it would be okay. Another downside would be the increased complexity (in terms of implementation and execution).
And finally our goal is to get rid of bad token detection soon-ish anyway so it might not make sense to spend time on the old stuff.

Some of the techniques that might come in handy have been used and described in #1575.

Basically this issue is just a braindump for the idea so we can track it if we actually want to do it.

Acceptance criteria

Bad token detection no longer depends on trace_many.

@MartinquaXD MartinquaXD changed the title chore: Get rid of trace_callMany dependency in bad token detection chore: Get rid of trace_many dependency in bad token detection Feb 19, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the Stale label Apr 20, 2024
@fleupold fleupold removed the Stale label Apr 20, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 20, 2024
@fleupold fleupold removed the stale label Jun 20, 2024
@MartinquaXD
Copy link
Contributor Author

We are considering to get rid of bad token detection completely in the near future so I think it no longer makes sense to tackle this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants