-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Get rid of trace_many
dependency in bad token detection
#2412
Comments
trace_callMany
dependency in bad token detectiontrace_many
dependency in bad token detection
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
We are considering to get rid of bad token detection completely in the near future so I think it no longer makes sense to tackle this issue. |
Background
Currently our bad token detection requires a node that supports
trace_many
which for example rules outgeth
. It should be possible to implement a similar logic using helper solidity contracts we use with state overrides.This would basically trade in the dependency on
trace_many
with state overrides. But we already have a very big dependency on that so it would be okay. Another downside would be the increased complexity (in terms of implementation and execution).And finally our goal is to get rid of bad token detection soon-ish anyway so it might not make sense to spend time on the old stuff.
Some of the techniques that might come in handy have been used and described in #1575.
Basically this issue is just a braindump for the idea so we can track it if we actually want to do it.
Acceptance criteria
Bad token detection no longer depends on
trace_many
.The text was updated successfully, but these errors were encountered: