Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Delete built-in price estimators #2321

Closed
MartinquaXD opened this issue Jan 23, 2024 · 3 comments
Closed

chore: Delete built-in price estimators #2321

MartinquaXD opened this issue Jan 23, 2024 · 3 comments
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details

Comments

@MartinquaXD
Copy link
Contributor

With most of the price estimations not going through built-in estimators we can delete many of them and simplify the price estimator factory. Basically a refresh of this PR
@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Jan 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Mar 24, 2024
@github-actions github-actions bot closed this as completed Apr 1, 2024
@MartinquaXD MartinquaXD reopened this Apr 2, 2024
@MartinquaXD MartinquaXD removed the stale label Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 2, 2024
@MartinquaXD
Copy link
Contributor Author

Fixed in #2619 and #2737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinquaXD