Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: When enabled discard quotes that fail verification #2318

Closed
MartinquaXD opened this issue Jan 23, 2024 · 1 comment
Closed

chore: When enabled discard quotes that fail verification #2318

MartinquaXD opened this issue Jan 23, 2024 · 1 comment
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details

Comments

@MartinquaXD
Copy link
Contributor

When #2310 is resolved we have the capacity to know which quotes are verified but we still don't act on that.
This PR captures the work to actually discard any quote that failed the verification when the feature is enabled.

This most likely requires adjustments in the competition price estimator.
@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Jan 23, 2024
@MartinquaXD
Copy link
Contributor Author

Currently we support opening orders which are not completely covered by user funds. That's why we cannot completely discard all quotes that can't be verified. But #2385 introduced a way to prefer verified quotes over unverified ones which would be the next best thing given the circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinquaXD