Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: A lot of orders without quote #2292

Closed
sunce86 opened this issue Jan 16, 2024 · 3 comments
Closed

bug: A lot of orders without quote #2292

sunce86 opened this issue Jan 16, 2024 · 3 comments
Labels
bug Something isn't working E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jan 16, 2024

Problem

Noticed a lot of orders are missing quotes which are required for protocol fee to work properly.

Each created order should have a quote attached.

https://production-6de61f.kb.eu-central-1.aws.cloud.es.io/app/r/s/57WmW
@sunce86 sunce86 added bug Something isn't working E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details labels Jan 16, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 16, 2024

All orders are created before 04.12.2023 when the quote storing was released: https://github.com/cowprotocol/services/releases/tag/v2.235.0

Closing.

@sunce86 sunce86 closed this as completed Jan 16, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 16, 2024

Reopening since they might be something we can do to avoid logs that will prevent us from seeing the real issues.

@sunce86 sunce86 reopened this Jan 16, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 19, 2024

Resolved with inserting fake quotes into db manually.

@sunce86 sunce86 closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunce86