Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Smart quote selection (canonical market) #9

Closed
anxolin opened this issue Apr 3, 2022 · 3 comments
Closed

Smart quote selection (canonical market) #9

anxolin opened this issue Apr 3, 2022 · 3 comments
Labels
Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 3, 2022

I'm pretty sure this issue was created, but I don't find it now. Maybe is a duplicate.

The explorer right now doesn't have a strategy to select how to display the price.

The result is that, for example buying and selling the same token pars will express the price differently. See these 2 orders:

image

image

For example in this case, the price should be expressed in DAI per WETH (by default).

For gpv1 we did a smart selection of the price, that was described here:
https://docs.google.com/document/d/1Hwoi8xBhPiOg-KqoeQEuWsg1WjGIXxrifWbMtvWJlME/edit

We should start with a simple strategy to have a better UX in terms of prices.

Original issue gnosis/gp-ui#331 by @anxolin

@anxolin anxolin added Low Severity indicator for defects. It won't cause any major break-down of the system Protofire app:Explorer Explorer App Enhancement New feature or request labels Apr 3, 2022
@anxolin anxolin added the Epic label Apr 20, 2022
@elena-zh elena-zh removed the Protofire label Dec 9, 2022
@anxolin
Copy link
Contributor Author

anxolin commented Jul 24, 2023

Now that we have the mono-repo, is super simple to share this logic in explorer

@nenadV91 if you get a chance this one would be good to have

@alfetopito
Copy link
Collaborator

Remember that the Explorer is not in the same mono-repo

@elena-zh
Copy link

Closing this in favor of cowprotocol/cowswap#3711

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

3 participants