-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@alfetopito Whyyyyyyy? I added this two: explorer/.github/workflows/vercel.yml Line 44 in c838c47
I added the secrets in Github and Vercel env (for dev). I tested locally (it works now thanks to the webpack config). It doesn't work in Vercel! (shows the infura key of the config file, and it doesn't pick the envs What am i missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know what's wrong, will try it out locally and play with Vercel to try to figure it out
ETH_NODE_URL: ${{ secrets.ETH_NODE_URL }} | ||
INFURA_ID: ${{ secrets.INFURA_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is only used in builds executed on GH Actions workflows, which are NOT the PR preview builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Vercel PREVIEW env var update, this PR is working.
There are some caveats I left as comments.
As for running locally, it no longer works when no env vars are set, which means the dev defaults are not being used.
ETH_NODE_URL: process.env.ETH_NODE_URL, | ||
INFURA_ID: process.env.INFURA_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that:
- INFURA_ID takes precedence. If this is set, ETH_NODE_URL won't be used at all, AFAICT
- If ETH_NODE_URL is chain specific, other chains might not work (I have not tested this but I assume that's what will happen)
Summary
This PR fixes 2 issues:
To Test
Hopefully now we use NodeReal for mainnet RPC, and we use the right infura key for the infura provider.