-
Notifications
You must be signed in to change notification settings - Fork 8
[Batch Viewer] Differentiate SELL and BUY orders #108
Conversation
Pull Request Test Coverage Report for Build 2452405573Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
|
Hey @matextrem , for some orders I can see this differentiation https://pr108--explorer.review.gnosisdev.com/gc/tx/0x3f1aac7fb6eef92e253defb065e39873cc494ef5f4ccfb2644792c7aba937857/?tab=graph |
@alfetopito @elena-zh I believe we need to cherry-pick the merge barn/prod responses commit to fix the grey arrows as we are using the orders' response to get the buy/sell type of each order. |
* fetch orders and order detail from barn and prod apis * fix methods that were using only the prod env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Closes #45
Updated batch viewer logic in order to add order kind to differentiate between SELL and BUY orders.
To Test
tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d
)