Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[Batch Viewer] Differentiate SELL and BUY orders #108

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

matextrem
Copy link
Contributor

Summary

Closes #45

Updated batch viewer logic in order to add order kind to differentiate between SELL and BUY orders.

Screen Shot 2022-06-06 at 22 37 47

To Test

  1. Open tx page and go to the batch diagram view. (i.e : tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d)
  • You will see red edges for SELL orders and GREEN edges for BUY ones.

@matextrem matextrem added Enhancement New feature or request Protofire labels Jun 7, 2022
@matextrem matextrem self-assigned this Jun 7, 2022
@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2452405573

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 44.121%

Files with Coverage Reduction New Missed Lines %
src/const.ts 16 81.82%
Totals Coverage Status
Change from base Build 2437563327: 0.0%
Covered Lines: 2172
Relevant Lines: 4190

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

@alfetopito
Copy link
Collaborator

alfetopito commented Jun 7, 2022

Henry (sorry) Mati, for some reason this one still shows grey edges

https://pr108--explorer.review.gnosisdev.com/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d?tab=graph

Screen Shot 2022-06-07 at 09 26 56

@elena-zh
Copy link

elena-zh commented Jun 7, 2022

Hey @matextrem , for some orders I can see this differentiation https://pr108--explorer.review.gnosisdev.com/gc/tx/0x3f1aac7fb6eef92e253defb065e39873cc494ef5f4ccfb2644792c7aba937857/?tab=graph
However, as @alfetopito , I do not see lines in red and in green for the diagram you provided.

@ramirotw
Copy link
Contributor

ramirotw commented Jun 7, 2022

@alfetopito @elena-zh I believe we need to cherry-pick the merge barn/prod responses commit to fix the grey arrows as we are using the orders' response to get the buy/sell type of each order.

* fetch orders and order detail from barn and prod apis

* fix methods that were using only the prod env
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matextrem matextrem merged commit 4264cd2 into develop Jun 9, 2022
@henrypalacios henrypalacios deleted the 45/batch-viewer-orders-kind branch June 9, 2022 12:14
@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate SELL and BUY orders in the batch viewer diagram
5 participants