Remove HTML minification support #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree and following your comment, I removed minify in #282 I did not see your PR before opening mine and it's already merged, so I'm going to close this one. Sorry for the waste of time |
|
Ha! Don't forget the issues, they seem to be in need of a bit of a cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#269 points out that htmlmin is unsupported and dead - this meant that in #273 it was switched to using htmlmin2 instead. However, I'm not sure that's any better - the repo had a few commits to fix the py3.13 / cgi incompatibility, then nothing.
I've come across various things about how slow htmlmin as well
So, how about we just remove it entirely? HTML minification is a pretty rare thing to require these days as far as I'm aware. Would anyone miss it? It's not tested anywhere.
TBH I'm not sure of the effectiveness of markdown minification either - looks like it's just doing a basic "strip blank lines" thing. Could just remove minification entirely...?
Closes #269, closes #189