Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the mario3 branch, the generated events.tsv are still called "mariostars" #50

Open
hyruuk opened this issue Jan 17, 2023 · 2 comments
Assignees

Comments

@hyruuk
Copy link
Contributor

hyruuk commented Jan 17, 2023

We should probably :

  • correct the names of the files that are already created
  • push an update to generate events files with the correct name ("mario3") instead
@hyruuk
Copy link
Contributor Author

hyruuk commented Jan 17, 2023

It actually seems that the update have already been pushed because sub-01 for example has events.tsv files that are properly named. We will just need to rename the files that were wrongly named.

@hyruuk
Copy link
Contributor Author

hyruuk commented Jan 18, 2023

Another thing to correct in the old events.tsv created by mario3 :

  • The duration field of the gym-retro_game trials is empty in the files wrongly named "mariostars". They could be corrected on the same pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants