-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create JSON sidecar with a few info for each bk2 #5
Comments
You are right that the file naming should be fixed to be more readable. The json sidecars could contain run-wide helpful info to filter levels without loading the bk2 files such as (naming to be polished).
In fact it should store all the variables included in a data.json such as
Ideally we would generated these jsons and filenames directly in task_stimuli code at acquisition time. |
Not sure how to generate this file without relying on reading them through a full gym-retro + shinobi.stimuli setup. This would probably need to be done outside the shinobi repo ? |
Not sure if this is on purpose, but the files and folder nomenclature in sourcedata/ seem to be inconsistent with BIDS standard.
For example, sessions are named "ses-shinobi_001" instead of "ses-001", and files are named : "sub-01_ses-shinobi_001_20200914-150431_ShinobiIIIReturnOfTheNinjaMaster-Genesis_Level5-0_003.bk2" instead of "sub-01_ses-001_task-shinobi_level-5_rep-003_gamedata.bk2.
To reproduce the formatting of the training dataset, .bk2 files could be associated with .json files that keep the timestamp information (currently in the filename) in the following format :
{"LevelStartTime": "2019-01-28 09:47:24", "LevelStartTimestamp": 1548686844.0, "Level": "Level1-0", "LevelRepetition": 1}
The text was updated successfully, but these errors were encountered: