Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup of 08-wasm etheruem light client #147

Open
5 tasks done
gjermundgaraba opened this issue Dec 4, 2024 · 0 comments
Open
5 tasks done

Code cleanup of 08-wasm etheruem light client #147

gjermundgaraba opened this issue Dec 4, 2024 · 0 comments
Labels
ethereum-light-client Issues related to the 08-wasm ethereum light client good practices Good code practices

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Dec 4, 2024

A final tracking issue for code cleanups to be done before the 08-wasm ethereum light client can be considered finished.

Add items here that will not be done in each individual PR to keep them moving a little faster.

  • Either remove config.rs (and the typenum dependency) or rewrite client_state and consensus_state to compile-time sized and clean up config.rs
  • Try to find a way to get rid of most, if not all, of the wrapped types in wrappers.rs (context: most of them are due to a seeming lack of tree_hash_root implementation on certain types, and tree_hash_derive not working in different scenarios). There might be a way to replace them with a few generic implementation if we are lucky 🙏 - as an alternative, maybe we can fix this in tree_hash_derive and get it upstreamed.
  • Clean up ethereum_utils::base64. The structure, API and everything there is very verbose and tacky. Hopefully many of those types can be made more generic or otherwise easier to deal with. If not, at least make the code nicer...
  • Either use ensure for all assertions, or remove it entirely. Can also consider if this could/should be a macro. (done in refactor: remove ethereum-utils and use ethereum sub-folder #186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ethereum-light-client Issues related to the 08-wasm ethereum light client good practices Good code practices
Projects
Status: Backlog
Development

No branches or pull requests

1 participant