Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS rewards that fail distribution are lost in the distribution module #2292

Closed
Tracked by #2286
mpoke opened this issue Sep 20, 2024 · 0 comments · Fixed by #2323
Closed
Tracked by #2286

ICS rewards that fail distribution are lost in the distribution module #2292

mpoke opened this issue Sep 20, 2024 · 0 comments · Fixed by #2323
Assignees
Labels
scope: provider Issues related to the provider chain source: codereview To indicate an issue found during a code review. type: bug Issues that need priority attention -- something isn't working

Comments

@mpoke
Copy link
Contributor

mpoke commented Sep 20, 2024

Problem

The ICS rewards intended for distribution to the validators in the consumer validator set are first moved to the distribution module account (see here). Then, these rewards are distributed to validators via the AllocateTokensToConsumerValidators method. However, the rewards that failed to be allocated remain in the distribution module account.

Closing criteria

Use the return value of AllocateTokensToConsumerValidators to compute the amount of rewards that were not distributed to validators and transfer them back from the distribution module account. These rewards should be left in the consumer_rewad_pool to be distributed next time.

@mpoke mpoke added scope: provider Issues related to the provider chain source: codereview To indicate an issue found during a code review. type: bug Issues that need priority attention -- something isn't working labels Sep 20, 2024
@mpoke mpoke added this to Cosmos Hub Sep 20, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 20, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 20, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Oct 4, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: provider Issues related to the provider chain source: codereview To indicate an issue found during a code review. type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants