Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate power-shaping parameters #2103

Closed
insumity opened this issue Jul 26, 2024 · 1 comment
Closed

Deduplicate power-shaping parameters #2103

insumity opened this issue Jul 26, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@insumity
Copy link
Contributor

insumity commented Jul 26, 2024 •
edited
Loading

Problem

As mentioned in this comment, power shaping parameters appear in multiple proto messages (e.g., in MsgConsumerAddition, MsgConsumerModification, ConsumerAdditionProposal).
It would be nice to get rid of those duplications and simplify the codebase.
This issue is mostly a reminder to verify that those duplications do not exist after we complete the Permissionless work.
@insumity insumity added good first issue Good for newcomers status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jul 26, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Jul 26, 2024
@insumity insumity removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Jul 26, 2024
@insumity insumity mentioned this issue Jul 26, 2024
Merged
21 tasks
@mpoke
Copy link
Contributor

mpoke commented Sep 17, 2024

This is fixed in ICS v6.0.0 with the introduction of the permissionless ICS feature.

@mpoke mpoke closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 🩹 F1: Triage to 👍 F4: Assessment in Cosmos Hub Sep 17, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insumity @mpoke