New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at migrating to cometbft-rs #1103

Draft

mzabaluev wants to merge 2 commits into main from mikhail/migrate-cometbft

Draft

First stab at migrating to cometbft-rs #1103

Bulk change of tendermint impots to cometbft

GitHub Actions / clippy failed Feb 28, 2024 in 0s

clippy

8 errors

Details

Results

Message level	Amount
Internal compiler error	0
Error	8
Warning	0
Note	0
Help	0

Versions

rustc 1.76.0 (07dca489a 2024-02-04)
cargo 1.76.0 (c84b36747 2024-01-18)
clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check failure on line 45 in ibc-clients/ics07-tendermint/types/src/misbehaviour.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
  --> ibc-clients/ics07-tendermint/types/src/misbehaviour.rs:45:37
   |
45 |     pub fn validate_basic(&self) -> Result<(), Error> {
   |                                     ^^^^^^^^^^^^^^^^^
   |
  ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
   |
76 |     VerificationError { detail: LightClientErrorDetail },
   |     ---------------------------------------------------- the largest variant contains at least 152 bytes
   |
   = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 119 in ibc-clients/ics07-tendermint/types/src/header.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
   --> ibc-clients/ics07-tendermint/types/src/header.rs:119:37
    |
119 |     pub fn validate_basic(&self) -> Result<(), Error> {
    |                                     ^^^^^^^^^^^^^^^^^
    |
   ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
    |
76  |     VerificationError { detail: LightClientErrorDetail },
    |     ---------------------------------------------------- the largest variant contains at least 152 bytes
    |
    = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 90 in ibc-clients/ics07-tendermint/types/src/header.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
  --> ibc-clients/ics07-tendermint/types/src/header.rs:90:81
   |
90 |     pub fn verify_chain_id_version_matches_height(&self, chain_id: &ChainId) -> Result<(), Error> {
   |                                                                                 ^^^^^^^^^^^^^^^^^
   |
  ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
   |
76 |     VerificationError { detail: LightClientErrorDetail },
   |     ---------------------------------------------------- the largest variant contains at least 152 bytes
   |
   = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 74 in ibc-clients/ics07-tendermint/types/src/header.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
  --> ibc-clients/ics07-tendermint/types/src/header.rs:74:10
   |
74 |     ) -> Result<TrustedBlockState<'a>, Error> {
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
  ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
   |
76 |     VerificationError { detail: LightClientErrorDetail },
   |     ---------------------------------------------------- the largest variant contains at least 152 bytes
   |
   = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 211 in ibc-clients/ics07-tendermint/types/src/client_state.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
   --> ibc-clients/ics07-tendermint/types/src/client_state.rs:211:46
    |
211 |     pub fn as_light_client_options(&self) -> Result<Options, Error> {
    |                                              ^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
    |
76  |     VerificationError { detail: LightClientErrorDetail },
    |     ---------------------------------------------------- the largest variant contains at least 152 bytes
    |
    = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 126 in ibc-clients/ics07-tendermint/types/src/client_state.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
   --> ibc-clients/ics07-tendermint/types/src/client_state.rs:126:31
    |
126 |     pub fn validate(&self) -> Result<(), Error> {
    |                               ^^^^^^^^^^^^^^^^^
    |
   ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
    |
76  |     VerificationError { detail: LightClientErrorDetail },
    |     ---------------------------------------------------- the largest variant contains at least 152 bytes
    |
    = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 112 in ibc-clients/ics07-tendermint/types/src/client_state.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
   --> ibc-clients/ics07-tendermint/types/src/client_state.rs:112:51
    |
112 |     pub fn with_header(self, header: TmHeader) -> Result<Self, Error> {
    |                                                   ^^^^^^^^^^^^^^^^^^^
    |
   ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
    |
76  |     VerificationError { detail: LightClientErrorDetail },
    |     ---------------------------------------------------- the largest variant contains at least 152 bytes
    |
    = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check failure on line 95 in ibc-clients/ics07-tendermint/types/src/client_state.rs

github-actions / clippy

the `Err`-variant returned from this function is very large

error: the `Err`-variant returned from this function is very large
  --> ibc-clients/ics07-tendermint/types/src/client_state.rs:95:10
   |
95 |     ) -> Result<Self, Error> {
   |          ^^^^^^^^^^^^^^^^^^^
   |
  ::: ibc-clients/ics07-tendermint/types/src/error.rs:76:5
   |
76 |     VerificationError { detail: LightClientErrorDetail },
   |     ---------------------------------------------------- the largest variant contains at least 152 bytes
   |
   = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
note: the lint level is defined here
  --> ibc-clients/ics07-tendermint/types/src/lib.rs:8:5
   |
8  |     warnings,
   |     ^^^^^^^^
   = note: `#[deny(clippy::result_large_err)]` implied by `#[deny(warnings)]`

View more details on GitHub Actions