Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store functions to the ChannelKeeper V2 that use the new provable paths #7366

Closed
Tracked by #7345
chatton opened this issue Oct 1, 2024 · 3 comments
Closed
Tracked by #7345
Assignees

Comments

@chatton
Copy link
Contributor

chatton commented Oct 1, 2024

The ChannelKeeper V2 should include new functions which fetch and write to the store using the new paths outlined in the spec.

e.g. the equivalent of channelkeeperv1.SetPacketCommitment

ref cosmos/ibc#1148

@chatton chatton moved this to Ready for Development in IBC-GO Eureka Oct 1, 2024
@chatton chatton self-assigned this Oct 2, 2024
@chatton chatton moved this from Ready for Development to In progress in IBC-GO Eureka Oct 2, 2024
@chatton
Copy link
Contributor Author

chatton commented Oct 2, 2024

Leaving issue in progress pending final spec changes

@DimitrisJim
Copy link
Contributor

think @AdityaSripal mentioned these are very unlikely to change. Should we close or wait until cosmos/ibc#1144 is merged?

@chatton
Copy link
Contributor Author

chatton commented Nov 11, 2024

Linked issue has been merged, we should be good to close!

@chatton chatton closed this as completed Nov 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in IBC-GO Eureka Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants