Mismatch of client type returned by ClientState and ConsensusState in 07-celestia

[crodriguezvega]

In the PR that adds a light client module for 07-celestia we have temporarily disabled this check in ValidateBasic of MsgCreateClient because for this light client we have a ClientState implementation that returns "07-celestia" when calling ClientType, but we use Tendermint's implementation of ConsensusState, whose ClientType function returns "07-tendermint".

Potential solutions discussed so far:

• Removing the check form ValidateBasic.
• Removing ClientType function from ConsensusState if not really needed, then we can remove the check in ValidateBasic. Light client modules should make sure that ConsensusState bytes unmarshal to the expected type.
• Adding a customs ConsensusState type to 07-celestia that wraps Tendermint's ConsensusState (in a similar way as it is done with the ClientState type).

ref: #6053 (comment)

[damiannolan]

Discussed with @AdityaSripal and grepped the codebase. Should be possible to remove ClientType() from ConsensusState and the checks in ValidateBasics.

If any incompatible consensus state is passed to the target light client module retrieve from clientState.ClientType() then unmarshalling will fail

[crodriguezvega]

Closed by #6137