From a2037c7ec3bd400c4aef358c176ca59e8660940a Mon Sep 17 00:00:00 2001 From: Gjermund Garaba Date: Fri, 20 Dec 2024 18:08:50 +0100 Subject: [PATCH 1/3] chore: fix spell-checker (#7774) * chore: fix spell-checker * install codespell with pip --- .github/workflows/spell-checker.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/spell-checker.yml b/.github/workflows/spell-checker.yml index 85f5845ea86..e2399eaa619 100644 --- a/.github/workflows/spell-checker.yml +++ b/.github/workflows/spell-checker.yml @@ -1,6 +1,7 @@ name: Spell Check on: + workflow_dispatch: pull_request: schedule: - cron: "0 12 * * *" @@ -15,11 +16,14 @@ jobs: steps: - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + with: + python-version: '3.12' + - name: Install codespell + run: pip install codespell - name: Run codespell continue-on-error: true - run: | - sudo apt-get install codespell -y - codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,.github" --ignore-words=.github/.codespellignore + run: codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,.github,*.pdf,*.tla" --ignore-words=.github/.codespellignore - uses: peter-evans/create-pull-request@v7 if: github.event_name != 'pull_request' with: From 3ffb0e7a15f87a16d1d8d83849be87d52bc29cde Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 20 Dec 2024 18:10:13 +0100 Subject: [PATCH 2/3] chore: spelling errors fixes (#7776) Co-authored-by: gjermundgaraba <1344105+gjermundgaraba@users.noreply.github.com> --- docs/versioned_docs/version-v4.6.x/04-migrations/05-v3-to-v4.md | 2 +- docs/versioned_docs/version-v5.4.x/04-migrations/05-v3-to-v4.md | 2 +- docs/versioned_docs/version-v6.3.x/04-migrations/05-v3-to-v4.md | 2 +- docs/versioned_docs/version-v7.8.x/05-migrations/05-v3-to-v4.md | 2 +- docs/versioned_docs/version-v8.5.x/00-intro.md | 2 +- .../versioned_docs/version-v8.5.x/01-ibc/06-channel-upgrades.md | 2 +- docs/versioned_docs/version-v8.5.x/05-migrations/05-v3-to-v4.md | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/versioned_docs/version-v4.6.x/04-migrations/05-v3-to-v4.md b/docs/versioned_docs/version-v4.6.x/04-migrations/05-v3-to-v4.md index d916ec51252..958c6bd1328 100644 --- a/docs/versioned_docs/version-v4.6.x/04-migrations/05-v3-to-v4.md +++ b/docs/versioned_docs/version-v4.6.x/04-migrations/05-v3-to-v4.md @@ -41,7 +41,7 @@ where `icaAuthIBCModule` is the Interchain Accounts authentication IBC Module. The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to configure the module correctly in order to incentivize IBC packets. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. diff --git a/docs/versioned_docs/version-v5.4.x/04-migrations/05-v3-to-v4.md b/docs/versioned_docs/version-v5.4.x/04-migrations/05-v3-to-v4.md index d916ec51252..958c6bd1328 100644 --- a/docs/versioned_docs/version-v5.4.x/04-migrations/05-v3-to-v4.md +++ b/docs/versioned_docs/version-v5.4.x/04-migrations/05-v3-to-v4.md @@ -41,7 +41,7 @@ where `icaAuthIBCModule` is the Interchain Accounts authentication IBC Module. The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to configure the module correctly in order to incentivize IBC packets. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. diff --git a/docs/versioned_docs/version-v6.3.x/04-migrations/05-v3-to-v4.md b/docs/versioned_docs/version-v6.3.x/04-migrations/05-v3-to-v4.md index 859e135b1d6..ce5db2233d9 100644 --- a/docs/versioned_docs/version-v6.3.x/04-migrations/05-v3-to-v4.md +++ b/docs/versioned_docs/version-v6.3.x/04-migrations/05-v3-to-v4.md @@ -41,7 +41,7 @@ where `icaAuthIBCModule` is the Interchain Accounts authentication IBC Module. The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](../03-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to configure the module correctly in order to incentivize IBC packets. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. diff --git a/docs/versioned_docs/version-v7.8.x/05-migrations/05-v3-to-v4.md b/docs/versioned_docs/version-v7.8.x/05-migrations/05-v3-to-v4.md index 0c6f5fa35e5..60cc1c924eb 100644 --- a/docs/versioned_docs/version-v7.8.x/05-migrations/05-v3-to-v4.md +++ b/docs/versioned_docs/version-v7.8.x/05-migrations/05-v3-to-v4.md @@ -41,7 +41,7 @@ where `icaAuthIBCModule` is the Interchain Accounts authentication IBC Module. The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](../04-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](../04-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to configure the module correctly in order to incentivize IBC packets. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. diff --git a/docs/versioned_docs/version-v8.5.x/00-intro.md b/docs/versioned_docs/version-v8.5.x/00-intro.md index 7f4a09fb1af..a21bdf40058 100644 --- a/docs/versioned_docs/version-v8.5.x/00-intro.md +++ b/docs/versioned_docs/version-v8.5.x/00-intro.md @@ -27,7 +27,7 @@ IBC provides a reliable, permissionless, and generic base layer (allowing for th - **IBC/TAO** comprises the Transport, Authentication, and Ordering of packets, i.e. the infrastructure layer. - **IBC/APP** consists of the application handlers for the data packets being passed over the transport layer. These include but are not limited to fungible token transfers (ICS-20), NFT transfers (ICS-721), and interchain accounts (ICS-27). -- **Application module:** groups any application, middleware or smart contract that may wrap downsteam application handlers to provide enhanced functionality. +- **Application module:** groups any application, middleware or smart contract that may wrap downstream application handlers to provide enhanced functionality. Note three crucial elements in the diagram: diff --git a/docs/versioned_docs/version-v8.5.x/01-ibc/06-channel-upgrades.md b/docs/versioned_docs/version-v8.5.x/01-ibc/06-channel-upgrades.md index 841d11f42fd..e8e7df83efd 100644 --- a/docs/versioned_docs/version-v8.5.x/01-ibc/06-channel-upgrades.md +++ b/docs/versioned_docs/version-v8.5.x/01-ibc/06-channel-upgrades.md @@ -132,7 +132,7 @@ type Channel struct { This will also set the upgrade timeout for the counterparty (i.e. the timeout before which the counterparty chain must move from `FLUSHING` to `FLUSHCOMPLETE`; if it doesn't then the chain will cancel the upgrade and write an error receipt). The timeout is a relative time duration in nanoseconds that can be changed with `MsgUpdateParams` and by default is 10 minutes. -The state will change to `FLUSHCOMPLETE` once there are no in-flight packets left and the channel end is ready to move to `OPEN`. This flush state will also have an impact on how a channel ugrade can be cancelled, as detailed below. +The state will change to `FLUSHCOMPLETE` once there are no in-flight packets left and the channel end is ready to move to `OPEN`. This flush state will also have an impact on how a channel upgrade can be cancelled, as detailed below. All other parameters will remain the same during the upgrade handshake until the upgrade handshake completes. When the channel is reset to `OPEN` on a successful upgrade handshake, the relevant fields on the channel end will be switched over to the `UpgradeFields` specified in the upgrade. diff --git a/docs/versioned_docs/version-v8.5.x/05-migrations/05-v3-to-v4.md b/docs/versioned_docs/version-v8.5.x/05-migrations/05-v3-to-v4.md index 6707286eadc..091e11375ef 100644 --- a/docs/versioned_docs/version-v8.5.x/05-migrations/05-v3-to-v4.md +++ b/docs/versioned_docs/version-v8.5.x/05-migrations/05-v3-to-v4.md @@ -41,7 +41,7 @@ where `icaAuthIBCModule` is the Interchain Accounts authentication IBC Module. The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](../04-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](../04-middleware/01-ics29-fee/02-integration.md) for an in depth guide on how to configure the module correctly in order to incentivize IBC packets. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. From a8369a944d2ac197fcc1ee49e9db4760255e28ac Mon Sep 17 00:00:00 2001 From: Gjermund Garaba Date: Fri, 20 Dec 2024 18:10:48 +0100 Subject: [PATCH 3/3] chore: remove unecessary/unused github actions (#7772) --- .github/workflows/discord-notify.yml | 16 ------------- .github/workflows/release.yml | 21 ---------------- .github/workflows/slack-notify.yaml | 17 ------------- .goreleaser.yml | 36 ---------------------------- 4 files changed, 90 deletions(-) delete mode 100644 .github/workflows/discord-notify.yml delete mode 100644 .github/workflows/slack-notify.yaml delete mode 100644 .goreleaser.yml diff --git a/.github/workflows/discord-notify.yml b/.github/workflows/discord-notify.yml deleted file mode 100644 index efc8d40559e..00000000000 --- a/.github/workflows/discord-notify.yml +++ /dev/null @@ -1,16 +0,0 @@ -name: Notify Discord on Release - -on: - release: - types: [published] - -jobs: - notify: - runs-on: ubuntu-latest - steps: - - name: Send Notification to Discord - uses: Ilshidur/action-discord@2.4.0 - with: - args: "A new release of ibc-go has been tagged! View it here: ${{ github.event.release.html_url }}" - webhook: ${{ secrets.DISCORD_WEBHOOK }} - diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 813b13fcc4a..524f98d6657 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,27 +11,6 @@ env: IMAGE_NAME: ibc-go-simd jobs: - goreleaser: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - uses: actions/setup-go@v5 - with: - go-version: '1.23' - - - name: Release - uses: goreleaser/goreleaser-action@v6 - if: startsWith(github.ref, 'refs/tags/') - with: - version: latest - args: release --rm-dist - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - publish-docker-image: runs-on: ubuntu-latest steps: diff --git a/.github/workflows/slack-notify.yaml b/.github/workflows/slack-notify.yaml deleted file mode 100644 index e57ee00e701..00000000000 --- a/.github/workflows/slack-notify.yaml +++ /dev/null @@ -1,17 +0,0 @@ -# This re-usable workflow file will trigger a Slack notification on the channel configure via the Webhook URL. -# It currently comments a number of fields, but you can add or remove them as you see fit. -# -# To configure a Slack Webhook URL, follow the instructions here: https://api.slack.com/messaging/webhooks -on: - workflow_call: - -jobs: - slack-notify: - runs-on: ubuntu-latest - steps: - - uses: 8398a7/action-slack@v3 - with: - status: 'failure' - fields: repo,message,commit,author,action,eventName,ref,workflow,job,took,pullRequest - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} \ No newline at end of file diff --git a/.goreleaser.yml b/.goreleaser.yml deleted file mode 100644 index 63ecd8822e7..00000000000 --- a/.goreleaser.yml +++ /dev/null @@ -1,36 +0,0 @@ -before: - hooks: - - go mod tidy - -builds: - - main: ./testing/simapp/simd/main.go - binary: simd - flags: - - -tags=netgo ledger - - -mod=readonly - ldflags: - - -s -w -X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" - env: - - CGO_ENABLED=0 - goos: - - linux - - windows - - darwin - # for goarch use defaults: 386, amd64 and arm64. - -checksum: - name_template: SHA256SUMS-{{.Version}}.txt - algorithm: sha256 - -release: - mode: keep-existing - prerelease: auto - -archives: - - name_template: "{{ .ProjectName }}_simd_v{{ .Version }}_{{ .Os }}_{{ .Arch }}" - files: - - LICENSE - - README.md - - RELEASES.md - - SECURITY.md - - CHANGELOG.md