From dec37e70fdb097edf9f8038aa3579aad97a7aec0 Mon Sep 17 00:00:00 2001 From: Reece Williams Date: Wed, 20 Mar 2024 22:54:17 -0500 Subject: [PATCH] fix typos --- .github/workflows/mispell.yml | 2 +- CONTRIBUTING.md | 2 +- .../packet-forward-middleware/packetforward/keeper/keeper.go | 2 +- .../testing/simapp/params/encoding.go | 2 +- modules/async-icq/keeper/cache_ctx.go | 2 +- modules/async-icq/module.go | 4 ++-- .../x/interquery/keeper/msg_server_send_query_all_balances.go | 2 +- modules/ibc-hooks/wasm_hook.go | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/mispell.yml b/.github/workflows/mispell.yml index 103eab12..98f50201 100644 --- a/.github/workflows/mispell.yml +++ b/.github/workflows/mispell.yml @@ -1,4 +1,4 @@ -name: Fix typos nightly +name: typos on: pull_request: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1f1af982..d0e53ce1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -23,7 +23,7 @@ For features, every module should have [interchain-test](https://github.com/stra For modules, ensure full test coverage and compatibility with the main branch. -## New contributer approval process +## New contributor approval process - [ ] Submit a Github issue titled "I should be a maintainer because..." - [ ] After approval, write privileges will be granted to a member of an external team. - [ ] Merging PRs will require approval from more than one team diff --git a/middleware/packet-forward-middleware/packetforward/keeper/keeper.go b/middleware/packet-forward-middleware/packetforward/keeper/keeper.go index 19763616..16c01ec9 100644 --- a/middleware/packet-forward-middleware/packetforward/keeper/keeper.go +++ b/middleware/packet-forward-middleware/packetforward/keeper/keeper.go @@ -260,7 +260,7 @@ func (k *Keeper) WriteAcknowledgementForForwardedPacket( ctx, transfertypes.ModuleName, newToken, ); err != nil { // NOTE: should not happen as the module account was - // retrieved on the step above and it has enough balace + // retrieved on the step above and it has enough balance // to burn. panic(fmt.Sprintf("cannot burn coins after a successful send from escrow account to module account: %v", err)) } diff --git a/middleware/packet-forward-middleware/testing/simapp/params/encoding.go b/middleware/packet-forward-middleware/testing/simapp/params/encoding.go index 84247b6e..259b1bc1 100644 --- a/middleware/packet-forward-middleware/testing/simapp/params/encoding.go +++ b/middleware/packet-forward-middleware/testing/simapp/params/encoding.go @@ -18,7 +18,7 @@ type EncodingConfig struct { // MakeTestEncodingConfig creates an EncodingConfig for a non-amino based test configuration. // This function should be used only internally (in the SDK). -// App user should'nt create new codecs - use the app.AppCodec instead. +// App user shouldn't create new codecs - use the app.AppCodec instead. // [DEPRECATED] func MakeTestEncodingConfig() EncodingConfig { cdc := codec.NewLegacyAmino() diff --git a/modules/async-icq/keeper/cache_ctx.go b/modules/async-icq/keeper/cache_ctx.go index 95c1a846..8a51b9e3 100644 --- a/modules/async-icq/keeper/cache_ctx.go +++ b/modules/async-icq/keeper/cache_ctx.go @@ -12,7 +12,7 @@ import ( sdk "github.com/cosmos/cosmos-sdk/types" ) -// This function lets you run the function f, but if theres an error or panic +// This function lets you run the function f, but if there's an error or panic // drop the state machine change and log the error. // If there is no error, proceeds as normal (but with some slowdown due to SDK store weirdness) // Try to avoid usage of iterators in f. diff --git a/modules/async-icq/module.go b/modules/async-icq/module.go index aab0801f..0c9f4170 100644 --- a/modules/async-icq/module.go +++ b/modules/async-icq/module.go @@ -54,7 +54,7 @@ func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage { return cdc.MustMarshalJSON(types.DefaultGenesis()) } -// ValidateGenesis performs genesis state validation for the IBC interchain acounts module +// ValidateGenesis performs genesis state validation for the IBC interchain accounts module func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingConfig, bz json.RawMessage) error { var gs types.GenesisState if err := cdc.UnmarshalJSON(bz, &gs); err != nil { @@ -103,7 +103,7 @@ func NewAppModule(keeper keeper.Keeper, ss exported.Subspace) AppModule { } } -// InitModule will initialize the interchain query moudule. It should only be +// InitModule will initialize the interchain query module. It should only be // called once and as an alternative to InitGenesis. func (am AppModule) InitModule(ctx sdk.Context, params types.Params) { if err := am.keeper.SetParams(ctx, params); err != nil { diff --git a/modules/async-icq/testing/demo-simapp/x/interquery/keeper/msg_server_send_query_all_balances.go b/modules/async-icq/testing/demo-simapp/x/interquery/keeper/msg_server_send_query_all_balances.go index b3d7b545..c94768bd 100644 --- a/modules/async-icq/testing/demo-simapp/x/interquery/keeper/msg_server_send_query_all_balances.go +++ b/modules/async-icq/testing/demo-simapp/x/interquery/keeper/msg_server_send_query_all_balances.go @@ -34,7 +34,7 @@ func (k msgServer) SendQueryAllBalances(goCtx context.Context, msg *types.MsgSen }, } - // timeoutTimestamp set to max value with the unsigned bit shifted to sastisfy hermes timestamp conversion + // timeoutTimestamp set to max value with the unsigned bit shifted to satisfy hermes timestamp conversion // it is the responsibility of the auth module developer to ensure an appropriate timeout timestamp timeoutTimestamp := ctx.BlockTime().Add(time.Minute).UnixNano() seq, err := k.SendQuery(ctx, types.PortID, msg.ChannelId, chanCap, reqs, clienttypes.ZeroHeight(), uint64(timeoutTimestamp)) diff --git a/modules/ibc-hooks/wasm_hook.go b/modules/ibc-hooks/wasm_hook.go index 0aef149b..91df074b 100644 --- a/modules/ibc-hooks/wasm_hook.go +++ b/modules/ibc-hooks/wasm_hook.go @@ -94,7 +94,7 @@ func (h WasmHooks) OnRecvPacketOverride(im IBCMiddleware, ctx sdk.Context, packe amount, ok := sdk.NewIntFromString(data.GetAmount()) if !ok { - // This should never happen, as it should've been caught in the underlaying call to OnRecvPacket, + // This should never happen, as it should've been caught in the underlying call to OnRecvPacket, // but returning here for completeness return NewEmitErrorAcknowledgement(ctx, types.ErrInvalidPacket, "Amount is not an int") }