fix(client/v2/autocli): prevent duplicate addition of customCommands #22576

fastfadingviolets · 2024-11-20T16:01:41Z

Description

Not every module's custom commands are prefixed by the name of the module. Because of how Gaia bootstraps its tx command, autocli can end up adding duplicate commands if it's only checking whether there's already a command with the module's name added to the CLI. This PR fixes this by adding a second check to autocli's enhanceCommandCommon.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features
- Support for off-chain signing and verification of files.
- Introduction of governance proposals.
- Launch of a transaction factory.
- Extended keyring interface with new types.
- Custom broadcast logic added.
Improvements
- Enhanced error messaging with possible enum values displayed.
- Keyring flags added in query commands.
Bug Fixes
- Resolved issues with unmarshalling in transactions.
- Fixed duplicate command additions in the command interface.
Breaking Changes
- Removed address codecs from specific options, shifting to context-based codecs.

coderabbitai · 2024-11-20T16:01:48Z

📝 Walkthrough

Walkthrough

The pull request includes updates to the client/v2 module's changelog, documenting new features, improvements, breaking changes, and bug fixes. Key new features are off-chain signing and verification, governance proposals, and a transaction factory. Improvements include enhanced error messaging and keyring flags in query commands. The changelog also notes the removal of address codecs and fixes for unmarshalling issues and duplicate command entries. Additionally, modifications to the enhanceCommandCommon function in the autocli package improve command handling and prevent unnecessary command creation.

Changes

File	Change Summary
client/v2/CHANGELOG.md	Updated to include new features (off-chain signing, governance proposals, transaction factory), improvements (keyring flags, error messaging), breaking changes (removal of address codecs), and bug fixes (unmarshalling, duplicate commands).
client/v2/autocli/common.go	Modified `enhanceCommandCommon` to check for existing sub-commands before enhancing custom commands and adjusted logic for module options.

Assessment against linked issues

Objective	Addressed	Explanation
Fix duplicate lines in help menu for gaiad tx (#3412)	✅

Possibly related PRs

fix(client/v2): correctly handle enhanced sub commands #21809: This PR addresses issues with command enhancements in the autocli package, specifically related to the handling of custom commands, which is relevant to the changes made in the main PR regarding command logic.
fix(client/v2): *big.Int unmarshal #21853: This PR fixes issues with *big.Int unmarshalling in transactions, which is directly related to the bug fix mentioned in the main PR.
feat(client/v2): add keyring flags in query commands #22443: This PR introduces keyring flags in query commands, which aligns with the improvements made in the main PR regarding keyring functionality and enhancements in query commands.

Suggested reviewers

JulianToledano
akhilkumarpilli
kocubinski

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

client/v2/CHANGELOG.md (1)
61-61: Consider adding more context to the changelog entry.

While the entry correctly references the issue, it would be more helpful for users to understand the specific problem that was fixed. Consider expanding it to:
-* [cosmos/gaia#3412](https://github.com/cosmos/gaia/issues/3412) Fix duplicate command addition in `autocli`
+* [cosmos/gaia#3412](https://github.com/cosmos/gaia/issues/3412) Fix duplicate command addition in `autocli` where certain module commands appeared multiple times in the CLI help menu
client/v2/autocli/common.go (1)
143-151: LGTM! Consider enhancing error handling consistency.

The additional check for custom commands with names different from their modules effectively prevents duplicate command creation, addressing the core issue. This is a solid fix for the duplicate entries problem reported in issue #3412.

Consider wrapping the error returns in a more descriptive error using fmt.Errorf for consistency with other error handling in the codebase:
 if hasModuleOptions { // check if we need to enhance the existing command
-  if err := enhanceCustomCmd(b, subCmd, cmdType, modOpts); err != nil {
-    return err
-  }
+  if err := enhanceCustomCmd(b, subCmd, cmdType, modOpts); err != nil {
+    return fmt.Errorf("failed to enhance existing custom command %s: %w", custom.Name(), err)
+  }
 }

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between efc05e8 and f2b0f2e.

📒 Files selected for processing (2)

client/v2/CHANGELOG.md (1 hunks)
client/v2/autocli/common.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

client/v2/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

client/v2/autocli/common.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

🔇 Additional comments (1)

client/v2/autocli/common.go (1)

143-151: Verify impact on existing custom commands.

Let's ensure this change doesn't affect existing command structures.

✅ Verification successful

Let me gather more specific information about the command registration and custom command handling.

Changes to custom command handling are safe and well-implemented

The code changes implement a safe enhancement to custom command handling in the CLI. The implementation:

Properly checks for existing commands using findSubCommand before adding or enhancing them
Maintains backward compatibility by preserving existing command structures
Has proper fallback mechanisms when commands don't exist
Correctly handles both module-named and custom-named commands through separate checks

The changes ensure that:

Custom commands are not duplicated
Existing command hierarchies are preserved
Command enhancement is optional and controlled via module options
Command name conflicts are properly handled

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for existing custom commands and their structure

# Look for custom command registrations
echo "Checking for custom command registrations..."
rg -A 5 "AddCommand\(.*custom.*\)" --type go

# Look for module command definitions
echo "Checking for module command definitions..."
rg "type.*Command.*struct" --type go

# Look for potential command name conflicts
echo "Checking for potential command name conflicts..."
rg "Use:.*\".*\"" --type go

Length of output: 25112

Script:

#!/bin/bash
# Check for custom command handling and registration patterns
echo "Checking custom command handling..."
rg -B 5 -A 5 "findSubCommand" --type go

echo "Checking command registration patterns..."
rg -B 5 -A 5 "Name\(\)" --type go | grep -A 5 -B 5 "custom"

echo "Checking for potential command conflicts..."
rg -B 3 -A 3 "enhanceCustomCmd" --type go

Length of output: 15246

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

client/v2/CHANGELOG.md (1)
61-61: Enhance the changelog entry description

While the entry correctly references the issue, consider making it more descriptive to better explain the fix:
-* [cosmos/gaia#3412](https://github.com/cosmos/gaia/issues/3412) Fix duplicate command addition in `autocli`
+* [cosmos/gaia#3412](https://github.com/cosmos/gaia/issues/3412) Fix duplicate command addition in `autocli` by improving command existence checks for non-prefixed module commands
This provides more context about the nature of the fix and aligns with the level of detail in other changelog entries.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f2b0f2e and f17e361.

📒 Files selected for processing (2)

client/v2/CHANGELOG.md (1 hunks)
client/v2/autocli/common.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

client/v2/autocli/common.go

🧰 Additional context used

📓 Path-based instructions (1)

client/v2/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🔇 Additional comments (1)

client/v2/CHANGELOG.md (1)

Line range hint 1-24: LGTM! Changelog structure follows best practices

The changelog follows the Keep a Changelog format and properly organizes entries into appropriate sections with clear version headers and dates.

client/v2/CHANGELOG.md

julienrbrt

That makes sense, thank you!

client/v2/CHANGELOG.md

akhilkumarpilli

utACK

Co-authored-by: Julien Robert <[email protected]>

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

client/v2/CHANGELOG.md (1)

61-61: Enhance the changelog entry with more details.

The current entry could be more descriptive about the root cause, impact, and solution.

Consider this more detailed entry:

-* [#22576](https://github.com/cosmos/cosmos-sdk/pull/22576) Fix duplicate command addition in `autocli` when custom enhanced command has a different name than module name
+* [#22576](https://github.com/cosmos/cosmos-sdk/pull/22576) Fix duplicate command entries in `autocli` help menu caused by custom enhanced commands having different names than their module names. The fix improves command name checking in `enhanceCommandCommon` to prevent unintended command duplication.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 78db252 and 5a039d2.

📒 Files selected for processing (1)

client/v2/CHANGELOG.md (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

client/v2/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

…22576) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 685218e)

…22576) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 685218e) # Conflicts: # client/v2/CHANGELOG.md

…(backport #22576) (#22614) Co-authored-by: violet <[email protected]>

…(backport #22576) (#22615) Co-authored-by: violet <[email protected]> Co-authored-by: Julien Robert <[email protected]>

* main: feat(serverv2): add benchmarks of (old) cacheKV vs branch (#22497) fix: match comets bls implmentation (#22613) feat(math): Upstream GDA based decimal type (#21982) fix(client/v2/autocli): prevent duplicate addition of customCommands (#22576) build(deps): Bump cosmossdk.io/math from 1.3.0 to 1.4.0 (#22580)

* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745) Co-authored-by: Rootul P <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773) Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767) Co-authored-by: Richard Gibson <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(store): add release date (cosmos#19797) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <[email protected]> Co-authored-by: Julien Robert <[email protected]> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <[email protected]> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <[email protected]> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <[email protected]> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <[email protected]> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <[email protected]> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <[email protected]> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <[email protected]> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <[email protected]> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <[email protected]> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <[email protected]> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <[email protected]> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <[email protected]> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <[email protected]> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <[email protected]> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <[email protected]> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <[email protected]> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo <[email protected]> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <[email protected]> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <[email protected]> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: correct date cl v0.50.10 (cosmos#21832) * feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840) Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861) Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886) Co-authored-by: Marko <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910) Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: update gov docs (backport cosmos#22048) (cosmos#22050) * docs(keys): remove unsupported `--dry-run` flag description for `keys migrate` (backport cosmos#22057) (cosmos#22070) Co-authored-by: tutufen <[email protected]> * chore: Revert "docs: update gov docs (backport cosmos#22048)" (cosmos#22064) * docs(x/genutil): fix `genesis migrate` command examples (backport cosmos#22090) (cosmos#22097) Co-authored-by: tutufen <[email protected]> * chore(simapp): be consistent with runtime (cosmos#22203) * docs: add docs boilerplate (backport cosmos#22202) (cosmos#22210) Co-authored-by: Julien Robert <[email protected]> * fix(x/tx): sort with oneof field name in amino-json (backport cosmos#21782) (cosmos#22228) Co-authored-by: Luis Carvalho <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(x/group): update supported flags (backport cosmos#22229) (cosmos#22231) Co-authored-by: Julien Robert <[email protected]> * fix(x/group): proper address rendering in error (backport cosmos#22425) (cosmos#22432) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): add keyring flags in query commands (backport cosmos#22443) (cosmos#22445) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/depinject from 1.0.0 to 1.1.0 (cosmos#22463) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sontrinh16 <[email protected]> * build(deps): Bump actions/xxx-artifact from v3 to v4 (cosmos#22473) * fix(server): fix fallback genesis path (backport cosmos#22564) (cosmos#22573) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/math from 1.3.0 to 1.4.0 (cosmos#22607) * fix(client/v2/autocli): prevent duplicate addition of customCommands (backport cosmos#22576) (cosmos#22615) Co-authored-by: violet <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/cosmos-db from 1.0.2 to 1.1.0 (cosmos#22638) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 1.2.0 to 1.2.2 (cosmos#22662) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.11 (cosmos#22643) * fix(client/v2/autocli): add CoinDec flag (backport cosmos#22817) (cosmos#22821) Co-authored-by: Julián Toledano <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/tx): fix amino json drift from legacy spec (backport cosmos#21825) (cosmos#22088) * build(deps): Bump cosmossdk.io/x/tx from 0.13.6-0.20241003112805-ff8789a02871 to 0.13.6 (cosmos#22844) Co-authored-by: Julien Robert <[email protected]> * chore: edit changelog store (partial backport cosmos#22864) (cosmos#22884) Co-authored-by: Julien Robert <[email protected]> * Merge commit from fork * Limit recursion depth for unknown field detection (cherry picked from commit f038dc731c55be1e1c526e67695acc358631afd6) * Limit unpack any (cherry picked from commit 1a2bff56fb7391f9ce87d4fbe9e0367ae991c0b2) * Update Changelog * Another limit recursion depth for unknown field detection * Update changelog * chore: prep v0.50.11 release notes (cosmos#22898) * Mark v0.50.11-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rootul P <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Richard Gibson <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Cool Developer <[email protected]> Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: Kien <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Leon <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: cocoyeal <[email protected]> Co-authored-by: PolyMa <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: KI <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: lilasxie <[email protected]> Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: tutufen <[email protected]> Co-authored-by: Luis Carvalho <[email protected]> Co-authored-by: auricom <[email protected]> Co-authored-by: violet <[email protected]> Co-authored-by: Julián Toledano <[email protected]>

fastfadingviolets requested review from julienrbrt, JulianToledano and a team as code owners November 20, 2024 16:01

github-actions bot added the C:CLI label Nov 20, 2024

coderabbitai bot reviewed Nov 20, 2024

View reviewed changes

fastfadingviolets force-pushed the fix/duplicate-autocli-commands branch from f2b0f2e to f17e361 Compare November 20, 2024 16:10

coderabbitai bot reviewed Nov 20, 2024

View reviewed changes

julienrbrt reviewed Nov 20, 2024

View reviewed changes

client/v2/CHANGELOG.md Outdated Show resolved Hide resolved

julienrbrt assigned JulianToledano and julienrbrt Nov 20, 2024

julienrbrt changed the title ~~fix: prevent duplicate addition of customCommands by autocli~~ fix(client/v2/autocli): prevent duplicate addition of customCommands Nov 20, 2024

fix: prevent duplicate addition of customCommands by autocli

78db252

fastfadingviolets force-pushed the fix/duplicate-autocli-commands branch from f17e361 to 78db252 Compare November 20, 2024 22:15

julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release labels Nov 21, 2024

julienrbrt approved these changes Nov 21, 2024

View reviewed changes

client/v2/CHANGELOG.md Outdated Show resolved Hide resolved

akhilkumarpilli approved these changes Nov 21, 2024

View reviewed changes

JulianToledano approved these changes Nov 21, 2024

View reviewed changes

fastfadingviolets and others added 2 commits November 21, 2024 09:47

Update client/v2/CHANGELOG.md

d60e740

Co-authored-by: Julien Robert <[email protected]>

Merge branch 'main' into fix/duplicate-autocli-commands

5a039d2

julienrbrt added this pull request to the merge queue Nov 21, 2024

coderabbitai bot reviewed Nov 21, 2024

View reviewed changes

Merged via the queue into cosmos:main with commit 685218e Nov 21, 2024
69 of 71 checks passed

mergify bot pushed a commit that referenced this pull request Nov 21, 2024

fix(client/v2/autocli): prevent duplicate addition of customCommands (#…

93b8d10

…22576) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 685218e)

mergify bot pushed a commit that referenced this pull request Nov 21, 2024

fix(client/v2/autocli): prevent duplicate addition of customCommands (#…

3dad36d

…22576) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 685218e) # Conflicts: # client/v2/CHANGELOG.md

This was referenced Nov 21, 2024

fix(client/v2/autocli): prevent duplicate addition of customCommands (backport #22576) #22614

Merged

fix(client/v2/autocli): prevent duplicate addition of customCommands (backport #22576) #22615

Merged

julienrbrt pushed a commit that referenced this pull request Nov 21, 2024

fix(client/v2/autocli): prevent duplicate addition of customCommands …

0d34054

…(backport #22576) (#22614) Co-authored-by: violet <[email protected]>

julienrbrt added a commit that referenced this pull request Nov 21, 2024

fix(client/v2/autocli): prevent duplicate addition of customCommands …

8210b50

…(backport #22576) (#22615) Co-authored-by: violet <[email protected]> Co-authored-by: Julien Robert <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(client/v2/autocli): prevent duplicate addition of customCommands #22576

fix(client/v2/autocli): prevent duplicate addition of customCommands #22576

fastfadingviolets commented Nov 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 20, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

julienrbrt left a comment

akhilkumarpilli left a comment

coderabbitai bot left a comment

fix(client/v2/autocli): prevent duplicate addition of customCommands #22576

fix(client/v2/autocli): prevent duplicate addition of customCommands #22576

Conversation

fastfadingviolets commented Nov 20, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Nov 20, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

akhilkumarpilli left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

fastfadingviolets commented Nov 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 20, 2024 •

edited

Loading