From 3b6fab08c4d6e649d00113271dd7387f2d365f9f Mon Sep 17 00:00:00 2001 From: alanprot Date: Tue, 17 Dec 2024 18:21:38 -0800 Subject: [PATCH] Update cortex_ingester_inflight_push_requests metric description Signed-off-by: alanprot --- CHANGELOG.md | 1 + pkg/ingester/metrics.go | 2 +- pkg/ingester/metrics_test.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6181aba0cb..c9f26389e5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ * [CHANGE] Change all max async concurrency default values `50` to `3` #6268 * [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency` from `50` to `3` #6265 * [CHANGE] Enable Compactor and Alertmanager in target all. #6204 +* [CHANGE] Update the `cortex_ingester_inflight_push_requests` metric to represent the maximum number of inflight requests recorded in the last minute. #6437 * [FEATURE] Ruler: Pagination support for List Rules API. #6299 * [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527 * [FEATURE] Ruler: Experimental: Add `ruler.frontend-address` to allow query to query frontends instead of ingesters. #6151 diff --git a/pkg/ingester/metrics.go b/pkg/ingester/metrics.go index 645f995868..e3e3d18d00 100644 --- a/pkg/ingester/metrics.go +++ b/pkg/ingester/metrics.go @@ -216,7 +216,7 @@ func newIngesterMetrics(r prometheus.Registerer, inflightRequests: promauto.With(r).NewGaugeFunc(prometheus.GaugeOpts{ Name: "cortex_ingester_inflight_push_requests", - Help: "Current number of inflight push requests in ingester.", + Help: "Max number of inflight push requests in ingester on the last minute.", }, func() float64 { if inflightPushRequests != nil { return float64(inflightPushRequests.Load()) diff --git a/pkg/ingester/metrics_test.go b/pkg/ingester/metrics_test.go index 031dec9482..ca40e05a7e 100644 --- a/pkg/ingester/metrics_test.go +++ b/pkg/ingester/metrics_test.go @@ -39,7 +39,7 @@ func TestIngesterMetrics(t *testing.T) { require.NotNil(t, m) err := testutil.GatherAndCompare(mainReg, bytes.NewBufferString(` - # HELP cortex_ingester_inflight_push_requests Current number of inflight push requests in ingester. + # HELP cortex_ingester_inflight_push_requests Max number of inflight push requests in ingester on the last minute. # TYPE cortex_ingester_inflight_push_requests gauge cortex_ingester_inflight_push_requests 14 # HELP cortex_ingester_max_inflight_query_requests Max number of inflight query requests in ingester.