diff --git a/CHANGELOG.md b/CHANGELOG.md index 08b4419b15..d1879b8737 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,7 +59,7 @@ * [ENHANCEMENT] Store Gateway: add metric `cortex_bucket_store_chunk_refetches_total` for number of chunk refetches. #5532 * [ENHANCEMENT] BasicLifeCycler: allow final-sleep during shutdown #5517 * [ENHANCEMENT] All: Handling CMK Access Denied errors. #5420 #5542 -* [ENHANCEMENT] Querier: Retry store gateway chunk pool exhaustion error and client connection closing gRPC error. #5558 +* [ENHANCEMENT] Querier: Retry store gateway client connection closing gRPC error. #5558 * [BUGFIX] Ruler: Validate if rule group can be safely converted back to rule group yaml from protobuf message #5265 * [BUGFIX] Querier: Convert gRPC `ResourceExhausted` status code from store gateway to 422 limit error. #5286 * [BUGFIX] Alertmanager: Route web-ui requests to the alertmanager distributor when sharding is enabled. #5293 diff --git a/pkg/querier/blocks_store_queryable.go b/pkg/querier/blocks_store_queryable.go index 49e8a31759..85a950c5c3 100644 --- a/pkg/querier/blocks_store_queryable.go +++ b/pkg/querier/blocks_store_queryable.go @@ -1120,7 +1120,6 @@ func isRetryableError(err error) bool { // https://github.com/grpc/grpc-go/blob/03172006f5d168fc646d87928d85cb9c4a480291/clientconn.go#L67 case codes.Canceled: return strings.Contains(err.Error(), "grpc: the client connection is closing") - // TODO(yeya24): change Thanos to use ResourceExhausted for chunk pool error. default: return false }