Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cl893/fix race conditions #221

Merged
merged 15 commits into from
Oct 3, 2024
Merged

Cl893/fix race conditions #221

merged 15 commits into from
Oct 3, 2024

Conversation

cathli66
Copy link
Contributor

@cathli66 cathli66 commented May 2, 2024 •
edited
Loading

Summary

This pull request fixes some last minute bugs encountered after deployment!

  • Fix race condition with I've Arrived modal popping up before completed challenge is called in the backend
  • Fixed bug where achievement trackers were not properly added for users
  • Minor UI changes to look good on iOS

@dti-github-bot
Copy link
Member

dti-github-bot commented May 2, 2024 •
edited
Loading

[diff-counting] Significant lines: 203.

@cathli66 cathli66 temporarily deployed to cornell-go-production May 2, 2024 08:01 Inactive
@cathli66 cathli66 temporarily deployed to cornell-go-production May 2, 2024 08:21 Inactive
@cathli66 cathli66 temporarily deployed to cornell-go-production May 2, 2024 18:55 Inactive
@neketka neketka temporarily deployed to cornell-go-production May 3, 2024 19:40 Inactive
@BrianLa0616
Copy link
Contributor

Is there a specific reason why you changed the return of completeChallenge from boolean to string? Does getting the name from a challenge not work?

BrianLa0616
BrianLa0616 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOAT Cathryn. Hopefully this doesn't break stuff 😭

We probably should have enums for difficulties instead of strings. Will work on that.

@BrianLa0616 BrianLa0616 merged commit 5e0fdf6 into master Oct 3, 2024
12 checks passed
@BrianLa0616 BrianLa0616 deleted the cl893/fix-race-conditions branch October 3, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianLa0616 BrianLa0616 BrianLa0616 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cathli66 @dti-github-bot @BrianLa0616 @neketka @syoung212