Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cl893/fix prod bugs #219

Merged
merged 14 commits into from
May 2, 2024
Merged

Cl893/fix prod bugs #219

merged 14 commits into from
May 2, 2024

Conversation

cathli66
Copy link
Contributor

@cathli66 cathli66 commented May 2, 2024

Summary

This pull request fixes UI bugs and joining org+ completing challenge bugs

@dti-github-bot
Copy link
Member

dti-github-bot commented May 2, 2024

[diff-counting] Significant lines: 516.

Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me!

@cathli66 cathli66 merged commit e4213d3 into master May 2, 2024
12 checks passed
@cathli66 cathli66 deleted the cl893/fix-prod-bugs branch May 2, 2024 01:14
@3TTemi
Copy link
Contributor

3TTemi commented May 6, 2024

There seems to be a lot of scattered comments that can be removed from the codebase. Also calculations made for size can be abstracted out for readability like in the progress bar widget. Otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants