Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameplay page UI Design #149

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Gameplay page UI Design #149

merged 10 commits into from
Mar 8, 2024

Conversation

cgu2020
Copy link
Contributor

@cgu2020 cgu2020 commented Feb 12, 2024

Summary

This pull request is the first step towards implementing gameplay page

  • UI designs
  • Dialog Boxes

These are the general elements of the Gameplay Page subject to be changed in the release. Backend is not connected and will be done in a separate PR.

Screenshot 2024-03-05 at 8 00 07 PM

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 12, 2024

[diff-counting] Significant lines: 190.

Copy link
Contributor

@nit0107 nit0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job updating the gameplay view and adding frontend features!

Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Some minor nits in the comments.

game/lib/gameplay/gameplay_page.dart Outdated Show resolved Hide resolved
game/lib/gameplay/gameplay_page.dart Outdated Show resolved Hide resolved
game/lib/gameplay/gameplay_page.dart Outdated Show resolved Hide resolved
game/lib/gameplay/gameplay_page.dart Outdated Show resolved Hide resolved
@cathli66
Copy link
Contributor

cathli66 commented Feb 21, 2024

No need to deal with google maps integration! I'm handling that part, just have the frontend ready and we can merge in the PR so I can add in the map. You could make a separate PR for connecting it to the backend after

@cgu2020 cgu2020 requested a review from neketka February 28, 2024 22:14
@cgu2020 cgu2020 changed the title Gameplay page and google maps Gameplay page UI Design Mar 6, 2024
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the UI stuff looks good to me! I guess you must have updated or reinstalled the dependencies to change package-lock.json? Weird that it would be completely rewritten

cathli66
cathli66 previously approved these changes Mar 8, 2024
@cathli66 cathli66 dismissed neketka’s stale review March 8, 2024 05:15

All requested changes were resolved

Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI matches the Figma designs!

@cathli66 cathli66 merged commit e69f344 into master Mar 8, 2024
10 checks passed
@cathli66 cathli66 deleted the gameplay-page branch March 8, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants