-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gameplay page UI Design #149
Conversation
[diff-counting] Significant lines: 190. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job updating the gameplay view and adding frontend features!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Some minor nits in the comments.
No need to deal with google maps integration! I'm handling that part, just have the frontend ready and we can merge in the PR so I can add in the map. You could make a separate PR for connecting it to the backend after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the UI stuff looks good to me! I guess you must have updated or reinstalled the dependencies to change package-lock.json? Weird that it would be completely rewritten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI matches the Figma designs!
Summary
This pull request is the first step towards implementing gameplay page
These are the general elements of the Gameplay Page subject to be changed in the release. Backend is not connected and will be done in a separate PR.